linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daisuke Matsuda <dskmtsd@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-rdma@vger.kernel.org, linux-mm@kvack.org, leon@kernel.org,
	jgg@ziepe.ca, akpm@linux-foundation.org, jglisse@redhat.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	zyjzyj2000@gmail.com
Subject: Re: [PATCH] mm/hmm: Allow hmm_dma_map_alloc() to tolerate NULL device
Date: Sat, 24 May 2025 00:56:07 +0900	[thread overview]
Message-ID: <56b45ad5-b3ae-40f2-bf3f-d0718e3d26c7@gmail.com> (raw)
In-Reply-To: <aDCXcbKwTdG3w5ZW@infradead.org>


On 2025/05/24 0:42, Christoph Hellwig wrote:
> Thank you very much, but I know rxe very well.  And given your apparent
> knowledge of the rdma subsystem you should also know pretty well that
> it does not otherwise call into the dma mapping core for virtual devices
> because calling into the dma mapping code is not valid for the virtual
> devices.
> 
> Please fix the rdma core to not call into the hmm dma mapping helpers
> for the ib_uses_virt_dma() case.
> 

Thank you for the clarification and guidance.

I'll look into updating the RDMA core to avoid calling hmm_dma_map_alloc() when ib_uses_virt_dma() is true. That should help keep the layering and responsibilities properly separated.

Thanks again,
Daisuke

      reply	other threads:[~2025-05-23 15:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 14:35 [PATCH] mm/hmm: Allow hmm_dma_map_alloc() to tolerate NULL device Daisuke Matsuda
2025-05-23 14:48 ` Christoph Hellwig
2025-05-23 15:38   ` Daisuke Matsuda
2025-05-23 15:42     ` Christoph Hellwig
2025-05-23 15:56       ` Daisuke Matsuda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56b45ad5-b3ae-40f2-bf3f-d0718e3d26c7@gmail.com \
    --to=dskmtsd@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).