linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Bjorn Helgaas <bhelgaas@google.com>,
	nofooter <nofooter@xilinx.com>
Subject: Re: PCIe MSI address is not written at pci_enable_msi_range call
Date: Mon, 11 Jul 2016 11:21:48 +0100	[thread overview]
Message-ID: <5783733C.70702@arm.com> (raw)
In-Reply-To: <8520D5D51A55D047800579B094147198258B81DF@XAP-PVEXMBX01.xlnx.xilinx.com>

[Please don't top-post]

On 11/07/16 10:33, Bharat Kumar Gogada wrote:
> Hi Marc,
> 
> Thanks for the reply.
> 
> From PCIe Spec:
> MSI Enable Bit:
> If 1 and the MSI-X Enable bit in the MSI-X Message
> Control register (see Section 6.8.2.3) is 0, the
> function is permitted to use MSI to request service
> and is prohibited from using its INTx# pin.
> 
> From Endpoint perspective, MSI Enable = 1 indicates MSI can be used which means MSI address and data fields are available/programmed.
> 
> In our SoC whenever MSI Enable goes from 0 --> 1 the hardware latches onto MSI address and MSI data values.
> 
> With current MSI implementation in kernel, our SoC is latching on to incorrect address and data values, as address/data
> are updated much later than MSI Enable bit.

Interesting. It looks like we're doing something wrong in the MSI flow.
Can you confirm that this is limited to MSI and doesn't affect MSI-X?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2016-07-11 10:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11  2:32 PCIe MSI address is not written at pci_enable_msi_range call Bharat Kumar Gogada
2016-07-11  8:47 ` Marc Zyngier
2016-07-11  9:33   ` Bharat Kumar Gogada
2016-07-11 10:21     ` Marc Zyngier [this message]
2016-07-11 10:51       ` Bharat Kumar Gogada
2016-07-11 15:50         ` Marc Zyngier
2016-07-12  9:11           ` Bharat Kumar Gogada
2016-07-12 14:28             ` Marc Zyngier
2016-07-12 15:56     ` Marc Zyngier
2016-07-13  6:22       ` Bharat Kumar Gogada
2016-07-13  8:16         ` Marc Zyngier
2016-07-13  8:33           ` Bharat Kumar Gogada
2016-07-13  8:37             ` Marc Zyngier
2016-07-13  9:10               ` Bharat Kumar Gogada
2016-07-13  9:19                 ` Marc Zyngier
2016-07-13  9:36                   ` Bharat Kumar Gogada
2016-07-13  9:40                     ` Marc Zyngier
2016-07-13 15:34                       ` Bharat Kumar Gogada
2016-07-13 15:39                         ` Marc Zyngier
2016-07-20 12:19             ` Marc Zyngier
2016-07-27 11:14               ` Bharat Kumar Gogada
  -- strict thread matches above, loose matches on Subject: below --
2016-07-11  2:37 Bharat Kumar Gogada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5783733C.70702@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=arnd@arndb.de \
    --cc=bharat.kumar.gogada@xilinx.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=nofooter@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).