* [PATCH -next] PCI: keystone: Fix error return code in ks_add_pcie_port()
@ 2016-07-28 16:16 Wei Yongjun
2016-07-28 16:29 ` Murali Karicheri
2016-08-22 19:33 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-07-28 16:16 UTC (permalink / raw)
To: Murali Karicheri, Bjorn Helgaas; +Cc: Wei Yongjun, linux-pci, linux-arm-kernel
Fix to return a negative error code from the request IRQ error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/pci/host/pci-keystone.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
index 8ba2883..82b461b 100644
--- a/drivers/pci/host/pci-keystone.c
+++ b/drivers/pci/host/pci-keystone.c
@@ -334,8 +334,9 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie,
if (ks_pcie->error_irq <= 0)
dev_info(&pdev->dev, "no error IRQ defined\n");
else {
- if (request_irq(ks_pcie->error_irq, pcie_err_irq_handler,
- IRQF_SHARED, "pcie-error-irq", ks_pcie) < 0) {
+ ret = request_irq(ks_pcie->error_irq, pcie_err_irq_handler,
+ IRQF_SHARED, "pcie-error-irq", ks_pcie);
+ if (ret < 0) {
dev_err(&pdev->dev, "failed to request error IRQ %d\n",
ks_pcie->error_irq);
return ret;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] PCI: keystone: Fix error return code in ks_add_pcie_port()
2016-07-28 16:16 [PATCH -next] PCI: keystone: Fix error return code in ks_add_pcie_port() Wei Yongjun
@ 2016-07-28 16:29 ` Murali Karicheri
2016-08-22 19:33 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Murali Karicheri @ 2016-07-28 16:29 UTC (permalink / raw)
To: Wei Yongjun, Bjorn Helgaas; +Cc: linux-pci, linux-arm-kernel
On 07/28/2016 12:16 PM, Wei Yongjun wrote:
> Fix to return a negative error code from the request IRQ error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> ---
> drivers/pci/host/pci-keystone.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
> index 8ba2883..82b461b 100644
> --- a/drivers/pci/host/pci-keystone.c
> +++ b/drivers/pci/host/pci-keystone.c
> @@ -334,8 +334,9 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie,
> if (ks_pcie->error_irq <= 0)
> dev_info(&pdev->dev, "no error IRQ defined\n");
> else {
> - if (request_irq(ks_pcie->error_irq, pcie_err_irq_handler,
> - IRQF_SHARED, "pcie-error-irq", ks_pcie) < 0) {
> + ret = request_irq(ks_pcie->error_irq, pcie_err_irq_handler,
> + IRQF_SHARED, "pcie-error-irq", ks_pcie);
> + if (ret < 0) {
> dev_err(&pdev->dev, "failed to request error IRQ %d\n",
> ks_pcie->error_irq);
> return ret;
>
Thanks
Acked-By: Murali Karicheri <m-karicheri2@ti.com>
--
Murali Karicheri
Linux Kernel, Keystone
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] PCI: keystone: Fix error return code in ks_add_pcie_port()
2016-07-28 16:16 [PATCH -next] PCI: keystone: Fix error return code in ks_add_pcie_port() Wei Yongjun
2016-07-28 16:29 ` Murali Karicheri
@ 2016-08-22 19:33 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2016-08-22 19:33 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Bjorn Helgaas, linux-pci, Murali Karicheri, linux-arm-kernel
On Thu, Jul 28, 2016 at 04:16:18PM +0000, Wei Yongjun wrote:
> Fix to return a negative error code from the request IRQ error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Applied with Murali's ack to pci/host-keystone for v4.9, thanks!
> ---
> drivers/pci/host/pci-keystone.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
> index 8ba2883..82b461b 100644
> --- a/drivers/pci/host/pci-keystone.c
> +++ b/drivers/pci/host/pci-keystone.c
> @@ -334,8 +334,9 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie,
> if (ks_pcie->error_irq <= 0)
> dev_info(&pdev->dev, "no error IRQ defined\n");
> else {
> - if (request_irq(ks_pcie->error_irq, pcie_err_irq_handler,
> - IRQF_SHARED, "pcie-error-irq", ks_pcie) < 0) {
> + ret = request_irq(ks_pcie->error_irq, pcie_err_irq_handler,
> + IRQF_SHARED, "pcie-error-irq", ks_pcie);
> + if (ret < 0) {
> dev_err(&pdev->dev, "failed to request error IRQ %d\n",
> ks_pcie->error_irq);
> return ret;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-22 19:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-28 16:16 [PATCH -next] PCI: keystone: Fix error return code in ks_add_pcie_port() Wei Yongjun
2016-07-28 16:29 ` Murali Karicheri
2016-08-22 19:33 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).