Re: [PATCH] xen: Remove event channel notification through Xen PCI platform device

Re: [PATCH] xen: Remove event channel notification through Xen PCI platform device

[Boris Ostrovsky]

On 08/26/2016 05:55 PM, KarimAllah Ahmed wrote:
> Ever since commit 254d1a3f02eb ("xen/pv-on-hvm kexec: shutdown watches
> from old kernel") using the INTx interrupt from Xen PCI platform device for
> event channel notification would just lockup the guest during bootup.
> postcore_initcall now calls xs_reset_watches which will eventually try to read
> a value from XenStore and will get stuck on read_reply at XenBus forever since
> the platform driver is not probed yet and its INTx interrupt handler is not
> registered yet. That means that the guest can not be notified at this moment of
> any pending event channels and none of the per-event handlers will ever be
> invoked (including the XenStore one) and the reply will never be picked up by
> the kernel.
>
> The exact stack where things get stuck during xenbus_init:
>
> -xenbus_init
>  -xs_init
>   -xs_reset_watches
>    -xenbus_scanf
>     -xenbus_read
>      -xs_single
>       -xs_single
>        -xs_talkv
>
> Vector callbacks have always been the favourite event notification mechanism
> since their introduction in commit 38e20b07efd5 ("x86/xen: event channels
> delivery on HVM.") and the vector callback feature has always been advertised
> for quite some time by Xen that's why INTx was broken for several years now
> without impacting anyone.
>
> Luckily this also means that event channel notification through INTx is
> basically dead-code which can be safely removed without impacting anybody since
> it has been effectively disabled for more than 4 years with nobody complaining
> about it (at least as far as I'm aware of).
>
> This commit removes event channel notification through Xen PCI platform device.
>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Julien Grall <julien.grall@citrix.com>
> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Ross Lagerwall <ross.lagerwall@citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Cc: Anthony Liguori <aliguori@amazon.com>
> Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Re: [Xen-devel] [PATCH] xen: Remove event channel notification through Xen PCI platform device

[David Vrabel]

On 26/08/16 22:55, KarimAllah Ahmed wrote:
> Ever since commit 254d1a3f02eb ("xen/pv-on-hvm kexec: shutdown watches
> from old kernel") using the INTx interrupt from Xen PCI platform device for
> event channel notification would just lockup the guest during bootup.
> postcore_initcall now calls xs_reset_watches which will eventually try to read
> a value from XenStore and will get stuck on read_reply at XenBus forever since
> the platform driver is not probed yet and its INTx interrupt handler is not
> registered yet. That means that the guest can not be notified at this moment of
> any pending event channels and none of the per-event handlers will ever be
> invoked (including the XenStore one) and the reply will never be picked up by
> the kernel.

Applied to for-linus-4.9, thanks.

David

Re: [Xen-devel] [PATCH] xen: Remove event channel notification through Xen PCI platform device

[Raslan, KarimAllah]

VW5mb3J0dW5hdGVseSwgdGhpcyBjb21taXQgaXMgcG90ZW50aWFsbHkgYSBjYW5kaWRhdGUgZm9y
IHJldmVydGluZy4gQWZ0ZXIgYQ0KbGVuZ3RoeSBxdWFsaWZpY2F0aW9uIEkgcmVhbGl6ZWQgdGhh
dCB0aGVyZSBpcyBhIGZ1bmN0aW9uIGNhbGxlZDoNCiJ4ZW5fc3RyaWN0X3hlbmJ1c19xdWlyaygp
IiB0aGF0IGlzIGJlaW5nIGNhbGxlZCBpbiB0aGUgb2ZmZW5kaW5nIHBhdGggdGhhdA0Kc2hvcnQt
Y2lyY3VpdHMgdGhlIG9mZmVuZGluZyBjb2RlIQ0KDQpTbyBhdCB0aGUgbW9tZW50IGFueSBkb21V
IGtlcm5lbCB3aXRoIHRoaXMgY29tbWl0IHdpbGwgbm90IGJvb3Qgb24gYW55IFhlbg0KdmVyc2lv
biA8IDQuMCEgIFNvIG5vYm9keSB3aXRoIFhlbiA8IDQuMCB3YXMgY29tcGxhaW5pbmcgbm90IGJl
Y2F1c2Ugbm9ib2R5IGlzDQp1c2luZyBpdCBidXQgcmF0aGVyIGJlY2F1c2UgdGhlcmUgaXMgYSBz
aG9ydC1jaXJjdWl0IGluIHRoZSBjb2RlIHRoYXQgYXZvaWRzDQpoaXR0aW5nIHRoZSBvZmZlbmRp
bmcgY29kZSBpbiB0aGUgZmlyc3QgcGxhY2UhIFNvIHRoZSBvcmlnaW5hbCBhc3N1bXB0aW9uIHRo
YXQNCnRoZSBjb2RlIGlzIGRlYWQgbWlnaHQgbm8gYmUgMTAwJSBjb3JyZWN0IQ0KDQpTbyBldmVu
IHRob3VnaCB0aGUgY29kZSBmb3IgSU5UeCBpcyBicm9rZW4gZm9yIGFueSBYZW4gPiA0LjAsIHRo
ZSByaWdodCB0aGluZw0KdG8gZG8gbm93IGlzIHRvIGFjdHVhbGx5IGZpeCB0aGUgSU5UeCBwcm9w
ZXJseSBhbmQgY29tcGxldGVseSByZXZlcnQgdGhpcw0KY29tbWl0IChhY3R1YWxseSBub3cgYWxz
byBjb21taXQgZGE3MmZmNWJmY2IwIG5lZWRzIHRvIGJlIHJldmVydGVkIHRvIGNsZWFubHkNCnJl
dmVydCB0aGlzIGNvbW1pdCkgdG8gYXZvaWQgYW55IHBvdGVudGlhbCByZWdyZXNzaW9uLg0KDQpE
YXZpZCwNCkRvZXMgdGhpcyBtYWtlIHNlbnNlIHRvIHlvdT8NCg0KSSB3aWxsIHNlbmQgYSBwYXRj
aCB0byBmaXggSU5UeCBzaG9ydGx5IGFzIHdlbGwuDQoNCk9uIDkvMzAvMTYsIDQ6NDYgUE0sICJE
YXZpZCBWcmFiZWwiIDxkYXZpZC52cmFiZWxAY2l0cml4LmNvbT4gd3JvdGU6DQoNCiAgICBPbiAy
Ni8wOC8xNiAyMjo1NSwgS2FyaW1BbGxhaCBBaG1lZCB3cm90ZToNCiAgICA+IEV2ZXIgc2luY2Ug
Y29tbWl0IDI1NGQxYTNmMDJlYiAoInhlbi9wdi1vbi1odm0ga2V4ZWM6IHNodXRkb3duIHdhdGNo
ZXMNCiAgICA+IGZyb20gb2xkIGtlcm5lbCIpIHVzaW5nIHRoZSBJTlR4IGludGVycnVwdCBmcm9t
IFhlbiBQQ0kgcGxhdGZvcm0gZGV2aWNlIGZvcg0KICAgID4gZXZlbnQgY2hhbm5lbCBub3RpZmlj
YXRpb24gd291bGQganVzdCBsb2NrdXAgdGhlIGd1ZXN0IGR1cmluZyBib290dXAuDQogICAgPiBw
b3N0Y29yZV9pbml0Y2FsbCBub3cgY2FsbHMgeHNfcmVzZXRfd2F0Y2hlcyB3aGljaCB3aWxsIGV2
ZW50dWFsbHkgdHJ5IHRvIHJlYWQNCiAgICA+IGEgdmFsdWUgZnJvbSBYZW5TdG9yZSBhbmQgd2ls
bCBnZXQgc3R1Y2sgb24gcmVhZF9yZXBseSBhdCBYZW5CdXMgZm9yZXZlciBzaW5jZQ0KICAgID4g
dGhlIHBsYXRmb3JtIGRyaXZlciBpcyBub3QgcHJvYmVkIHlldCBhbmQgaXRzIElOVHggaW50ZXJy
dXB0IGhhbmRsZXIgaXMgbm90DQogICAgPiByZWdpc3RlcmVkIHlldC4gVGhhdCBtZWFucyB0aGF0
IHRoZSBndWVzdCBjYW4gbm90IGJlIG5vdGlmaWVkIGF0IHRoaXMgbW9tZW50IG9mDQogICAgPiBh
bnkgcGVuZGluZyBldmVudCBjaGFubmVscyBhbmQgbm9uZSBvZiB0aGUgcGVyLWV2ZW50IGhhbmRs
ZXJzIHdpbGwgZXZlciBiZQ0KICAgID4gaW52b2tlZCAoaW5jbHVkaW5nIHRoZSBYZW5TdG9yZSBv
bmUpIGFuZCB0aGUgcmVwbHkgd2lsbCBuZXZlciBiZSBwaWNrZWQgdXAgYnkNCiAgICA+IHRoZSBr
ZXJuZWwuDQogICAgDQogICAgQXBwbGllZCB0byBmb3ItbGludXMtNC45LCB0aGFua3MuDQogICAg
DQogICAgRGF2aWQNCiAgICANCiAgICANCiAgICANCg0KQW1hem9uIERldmVsb3BtZW50IENlbnRl
ciBHZXJtYW55IEdtYkgKQmVybGluIC0gRHJlc2RlbiAtIEFhY2hlbgptYWluIG9mZmljZTogS3Jh
dXNlbnN0ci4gMzgsIDEwMTE3IEJlcmxpbgpHZXNjaGFlZnRzZnVlaHJlcjogRHIuIFJhbGYgSGVy
YnJpY2gsIENocmlzdGlhbiBTY2hsYWVnZXIKVXN0LUlEOiBERTI4OTIzNzg3OQpFaW5nZXRyYWdl
biBhbSBBbXRzZ2VyaWNodCBDaGFybG90dGVuYnVyZyBIUkIgMTQ5MTczIEIK