From: Prarit Bhargava <prarit@redhat.com>
To: Keith Busch <keith.busch@intel.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org, alex.williamson@redhat.com,
darcari@redhat.com, mstowe@redhat.com, bhelgaas@google.com,
lukas@wunner.de, mika.westerberg@linux.intel.com
Subject: Re: [PATCH] pci: Only disable MSI/X and enable INTx if shutdown function has been called
Date: Wed, 09 Nov 2016 14:49:12 -0500 [thread overview]
Message-ID: <58237DB8.9030009@redhat.com> (raw)
In-Reply-To: <20161109195458.GA3409@localhost.localdomain>
On 11/09/2016 02:54 PM, Keith Busch wrote:
> On Wed, Nov 09, 2016 at 02:36:23PM -0500, Prarit Bhargava wrote:
>>
>>
>> On 11/09/2016 12:05 PM, Bjorn Helgaas wrote:
>>> Hi Prarit,
>>>
>>> Is there a bugzilla or other archive of configuration/dmesg/other info
>>
>> [I have only added Bjorn and myself to the BZ below. Please feel free to add
>> yourself.]
>>
>> Bjorn, unfortunately this won't be caught in a dmesg log because the filesystem
>> is unmounted by the time we shutdown the PCI devices in the halt/reboot path.
>>
>> The trace is only available from serial console, and I have opened up
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=187351
>>
>> to track this.
>>
>> I have added some additional links to other bugzillas which seem to show the
>> same behavior, and included a full serial console capture of the boot to the BZ.
>> The end of the log shows the unhandled irq stack trace for irq 16.
>
> Just researching where this came from, the behavior to shutdown msi/msix
> and enable intx was done in commit d52877c7b1 for some kexec issue,
> and I think that was wrong in the first place. We shouldn't be changing
> interrupt configuration out from under the drivers.
Yeah .. and it was RHEL specific? Or at least it seems that way.
P.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-11-09 19:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 17:57 [PATCH] pci: Only disable MSI/X and enable INTx if shutdown function has been called Prarit Bhargava
2016-11-09 17:05 ` Bjorn Helgaas
2016-11-09 19:36 ` Prarit Bhargava
2016-11-09 19:54 ` Keith Busch
2016-11-09 19:49 ` Prarit Bhargava [this message]
2016-12-16 16:48 ` Prarit Bhargava
2017-01-19 14:38 ` Bjorn Helgaas
2017-01-25 13:23 ` Prarit Bhargava
-- strict thread matches above, loose matches on Subject: below --
2017-01-26 19:07 Prarit Bhargava
2017-03-09 21:57 ` Bjorn Helgaas
2017-03-10 12:30 ` Prarit Bhargava
2017-03-30 11:59 ` Prarit Bhargava
2017-03-30 21:52 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58237DB8.9030009@redhat.com \
--to=prarit@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=darcari@redhat.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=mstowe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).