* Help about MSI support in PCI Express Bus support driver
@ 2016-12-22 8:51 Zhou Wang
2016-12-22 21:28 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Zhou Wang @ 2016-12-22 8:51 UTC (permalink / raw)
To: linux-pci
Cc: gabriele.paoloni, liudongdong (C), Wei Xu, zhangzhihai,
jiashi.lin, wangzhou1
Hi All,
I have noticed that MSI support in PCI Express Bus support driver does not match
with the PCIe spec.
In function init_service_irqs, we get interrupts of all PCIe port services.
We only use one MSI for all the PCIe port services, which does not match with
PCIe3.0 spec.
Interrupt Message Number bits are used to indicate which MSI vector will be used
for a PCIe port service. The related definitions can be found in 6.2.4.1.2 for AER,
6.7.3.4 for hotplug, 6.2.10.1 for DPC, 6.1.6 for PME.
So do we have a plan to fix this feature? just like what we did in pcie_port_enable_msix.
Please let me know if I missed something.
It will be very appreciated if anyone can share ideas about this problem!
Thanks,
Zhou
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Help about MSI support in PCI Express Bus support driver
2016-12-22 8:51 Help about MSI support in PCI Express Bus support driver Zhou Wang
@ 2016-12-22 21:28 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2016-12-22 21:28 UTC (permalink / raw)
To: Zhou Wang
Cc: linux-pci, gabriele.paoloni, liudongdong (C), Wei Xu, zhangzhihai,
jiashi.lin
On Thu, Dec 22, 2016 at 04:51:29PM +0800, Zhou Wang wrote:
> Hi All,
>
> I have noticed that MSI support in PCI Express Bus support driver does not match
> with the PCIe spec.
>
> In function init_service_irqs, we get interrupts of all PCIe port services.
> We only use one MSI for all the PCIe port services, which does not match with
> PCIe3.0 spec.
>
> Interrupt Message Number bits are used to indicate which MSI vector will be used
> for a PCIe port service. The related definitions can be found in 6.2.4.1.2 for AER,
> 6.7.3.4 for hotplug, 6.2.10.1 for DPC, 6.1.6 for PME.
>
> So do we have a plan to fix this feature? just like what we did in pcie_port_enable_msix.
I do not know of any plans for fixes here. If it's broken, it'd be
great if you fixed it!
Bjorn
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-22 21:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-22 8:51 Help about MSI support in PCI Express Bus support driver Zhou Wang
2016-12-22 21:28 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).