Re: [PATCH V4 17/22] dt-bindings: PCI: tegra194: Add monitor clock support

[Manikanta Maddireddy <mmaddireddy@nvidia.com>]

On 29/01/26 10:10 pm, Rob Herring wrote:
> On Mon, Jan 26, 2026 at 01:15:14PM +0530, Manikanta Maddireddy wrote:
>> From: Vidya Sagar <vidyas@nvidia.com>
>>
>> Tegra supports PCIe core clock monitoring for any rate changes that may be
>> happening because of the link speed changes. This is useful in tracking
>> any changes in the core clock that are not initiated by the software.
>>
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
>> ---
>> V4:
>> * None
>>
>> V3:
>> * This is a new patch in this series
>>
>>   .../devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml    | 6 +++++-
>>   .../devicetree/bindings/pci/nvidia,tegra194-pcie.yaml       | 6 +++++-
>>   2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
>> index 6d6052a2748f..ca5da919c347 100644
>> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
>> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
>> @@ -55,12 +55,16 @@ properties:
>>         - const: intr
>>   
>>     clocks:
>> +    minItems: 1
>>       items:
>> -      - description: module clock
>> +      - description: module's core clock
>> +      - description: module's monitor clock
> Drop "module's"
I will fix it in next version.
>
>>   
>>     clock-names:
>> +    minItems: 1
>>       items:
>>         - const: core
>> +      - const: core_m
> I would use "module" unless this corresponds to h/w documentation.
>
> Otherwise,
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Thank you for quick review.

HW register to enable the clock is core_m, so I am using same name.