From: James Puthukattukaran <james.puthukattukaran@oracle.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Sinan Kaya <okaya@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7] PCI: Workaround wrong flags completions for IDT switch
Date: Wed, 18 Oct 2017 16:22:26 -0400 [thread overview]
Message-ID: <59E7B802.5010907@oracle.com> (raw)
In-Reply-To: <20171011192704.GN25517@bhelgaas-glaptop.roam.corp.google.com>
On 10/11/2017 03:27 PM, Bjorn Helgaas wrote:
> On Tue, Sep 26, 2017 at 04:03:13PM -0400, Sinan Kaya wrote:
>> On 9/26/2017 3:52 PM, James Puthukattukaran wrote:
>>>> I think you want to do the part above as part of a quirk that runs before
>>>> the probe.
>>>
>>> I don't think there's a way to run this early enough?
>>
>> Bjorn?
>>
>> I have seen multiple quirk types in quirks.c some prefixed with EARLY and
>> other LATE.
>
> I'm hoping an early quirk on the switch would be early enough, since
> the workaround needs to be done for devices downstream from the
> switch.
>
The problem is that this won't work for hotplug, which is where this bug
is exposed. The issue is really moot for boot time since the requester
id for down stream devices was "locked in" prior to enabling ACS when
the BIOS probes the devices present. So, this issue is for when a device
is hotplugged downstream to this IDT switch.
James
next prev parent reply other threads:[~2017-10-18 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 20:05 [PATCH v7] PCI: Workaround wrong flags completions for IDT switch James Puthukattukaran
2017-09-19 23:36 ` Sinan Kaya
2017-09-26 19:52 ` James Puthukattukaran
2017-09-26 20:03 ` Sinan Kaya
2017-10-11 19:27 ` Bjorn Helgaas
2017-10-18 20:22 ` James Puthukattukaran [this message]
2018-03-06 19:15 ` [PATCH v8] " James Puthukattukaran
2017-10-11 19:25 ` [PATCH v7] " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59E7B802.5010907@oracle.com \
--to=james.puthukattukaran@oracle.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).