From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 801C2C43219 for ; Tue, 1 Mar 2022 08:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233455AbiCAImo (ORCPT ); Tue, 1 Mar 2022 03:42:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233472AbiCAImn (ORCPT ); Tue, 1 Mar 2022 03:42:43 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0AC188B1A for ; Tue, 1 Mar 2022 00:42:01 -0800 (PST) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 5AE543FCAF for ; Tue, 1 Mar 2022 08:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646124120; bh=dZm4dVdpcvNRhKnzE3iapZ6aqr4LkpURHZ0F0cP2Ffk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lbftfQbaBU844nsZQB31PSLptIySJ/JrJsUhYj9C/gK/ETMAIBRyjckV3rzW7rX2n 5XX9HWyAxrW9+FpO8SUN4Putjgwt64v62kPOwDuWMUgGdWGQQ8nGhhOcCREbV2acwW LpKVZEtkmXEGBsN+I3xBM8X8vRAOuOUV30ZE/h5Kz28oo0WP+/eAgWzhVrBhHzIyhv Ooq3sO742mRLCT8mg2/FsXYQvtVAkix6RNFvhU8eIWKIx3EjqDb2gQjrr0r/tayLaD 3AhGFjSF7GG+B+Pln9+oLk0El5Xxnsh9O4dDG/FFwtudKz3/M/zRiWiA2yNJCL+NpA ztoPouzOVcEUQ== Received: by mail-ej1-f72.google.com with SMTP id h22-20020a1709060f5600b006b11a2d3dcfso6495070ejj.4 for ; Tue, 01 Mar 2022 00:42:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dZm4dVdpcvNRhKnzE3iapZ6aqr4LkpURHZ0F0cP2Ffk=; b=6NNq0JzggReIXBb0wQonnNbTNXXs2xhtUucpWMbYOo18zpr1PzX0MAVoGCct/Um21F Ehv4afZwYEDr413jYVgbVqyQT04dEo1sV05gomw2r3cXFZPqSV2cjUoXPRbsRpKTqA/V xBaI/efx/PsRHlhizheWvJeP+DfI5solS307OEXs+UI7/jYmZKNd4bPsrPEQMYq79RiV w47EH+7N+DIhBburD0l+ubdIfxNKdjtVL4mxDJtrYqZryoekdGdb2GWqb/8cX6NWCjVY U8mVv/QxhnsWTgF8z3WgKsyH4QX/b+coRlBMSMWDRC8njg/dArJvJ6HIQa1IJiVH9gm9 edDQ== X-Gm-Message-State: AOAM533WVsPEATn7LpxVPox8idg2Q4heYJMN7TvQEjOo6xHfR/BemkrH 6iuJE4hu4mm45UDjLfXYjhmjaHQDZsRYxuT1f5AOmiYyF4dQKFXdeUeVppvjRV8fTpRyh4KZd9n ax4WfxHcdC1ke89eP1e+N9LN4Ufy77NQ4Y/08ug== X-Received: by 2002:a17:907:248a:b0:69b:ba2d:62cd with SMTP id zg10-20020a170907248a00b0069bba2d62cdmr18284913ejb.212.1646124119341; Tue, 01 Mar 2022 00:41:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkLsXZPJFLzXPV5FGYgxl+qkbahIyWcZp4Gh4Ixdg/+bf55XzGLZMALWtwePubTl5fD9ILsg== X-Received: by 2002:a17:907:248a:b0:69b:ba2d:62cd with SMTP id zg10-20020a170907248a00b0069bba2d62cdmr18284886ejb.212.1646124119100; Tue, 01 Mar 2022 00:41:59 -0800 (PST) Received: from [192.168.0.135] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id bo14-20020a170906d04e00b006ce98d9c3e3sm5116757ejb.194.2022.03.01.00.41.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Mar 2022 00:41:58 -0800 (PST) Message-ID: <59ba1fd5-4be5-278f-47df-d26c341da73a@canonical.com> Date: Tue, 1 Mar 2022 09:41:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 05/11] PCI: Use driver_set_override() instead of open-coding Content-Language: en-US To: Bjorn Helgaas Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes References: <20220228200606.GA516338@bhelgaas> From: Krzysztof Kozlowski In-Reply-To: <20220228200606.GA516338@bhelgaas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 28/02/2022 21:06, Bjorn Helgaas wrote: > On Sun, Feb 27, 2022 at 02:52:08PM +0100, Krzysztof Kozlowski wrote: >> Use a helper for seting driver_override to reduce amount of duplicated >> code. Make the driver_override field const char, because it is not >> modified by the core and it matches other subsystems. > > s/seting/setting/ > or even better, s/for seting/to set/ > >> Signed-off-by: Krzysztof Kozlowski > > Acked-by: Bjorn Helgaas > >> - char *driver_override; /* Driver name to force a match */ >> + /* >> + * Driver name to force a match. >> + * Do not set directly, because core frees it. >> + * Use driver_set_override() to set or clear it. > > Wrap this comment to fill 78 columns or so. Thanks, I'll fix both. Best regards, Krzysztof