Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Karolina Stolarek <karolina.stolarek@oracle.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Jon Pan-Doh <pandoh@google.com>,
	Terry Bowman <terry.bowman@amd.com>, Len Brown <lenb@kernel.org>,
	James Morse <james.morse@arm.com>,
	Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
	Ben Cheatham <Benjamin.Cheatham@amd.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Shuai Xue <xueshuai@linux.alibaba.com>,
	Liu Xinpeng <liuxp11@chinatelecom.cn>,
	Darren Hart <darren@os.amperecomputing.com>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI/AER: Consolidate CXL, ACPI GHES and native AER reporting paths
Date: Thu, 24 Apr 2025 11:01:11 +0200	[thread overview]
Message-ID: <5a92a75f-4348-4578-9b61-45682edaa514@oracle.com> (raw)
In-Reply-To: <20250423203143.GA442813@bhelgaas>

On 23/04/2025 22:31, Bjorn Helgaas wrote:
> On Wed, Apr 23, 2025 at 03:52:27PM +0200, Karolina Stolarek wrote:
>>
>> I wasn't able to produce logs for the CXL path (that is, Restricted CXL
>> Device, as CXL1.1 devices not supported by the driver due to a missing
>> functionality; confirmed by Terry) and faced issues when trying to inject
>> errors via GHES. Is the lack of logs a blocker for this patch? I tested
>> other CXL scenarios and my changes didn't cause regression, as far as I
>> know.
> 
> Yes, I do think we need to say something about the output format
> changes.

I understand.

> I assume you're trying GHES on machines that actually do
> firmware-first error handling, right?  I found several GHES logs by
> searching the web for "APEI Generic Hardware Error Source" "PCIe
> error".  The majority were Dell boxes.

The only way to inject GHES errors I'm aware of is Mauro's patch for 
qemu[1], so I went down the virtualization path. As for working with the 
actual hardware, I'd need to ask around and learn more about the platform.

> If you can't produce actual logs for comparison, I think we can take
> info from a sample log somebody has posted and synthesize what the
> changes would be after this patch.

I also found some logs at some point, mostly from 2021 and 2023, but I 
felt bad about mocking up the messages and tried to produce actual logs. 
If I can't find a way to get this working in two weeks, I'll revisit 
this idea.

All the best,
Karolina

-------------------------------------------------------------
[1] - 
https://lore.kernel.org/lkml/76824dfc6bb5dd23a9f04607a907ac4ccf7cb147.1740653898.git.mchehab+huawei@kernel.org/

  reply	other threads:[~2025-04-24  9:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 15:07 [PATCH v2] PCI/AER: Consolidate CXL, ACPI GHES and native AER reporting paths Karolina Stolarek
2025-04-01  1:47 ` Jon Pan-Doh
2025-04-04  9:33   ` Karolina Stolarek
2025-04-23 13:52 ` Karolina Stolarek
2025-04-23 20:31   ` Bjorn Helgaas
2025-04-24  9:01     ` Karolina Stolarek [this message]
2025-04-24 17:28       ` Bjorn Helgaas
2025-04-25 10:32         ` Karolina Stolarek
2025-04-25 13:14           ` Jonathan Cameron
2025-04-25 14:12             ` Karolina Stolarek
2025-04-29 15:54               ` Jonathan Cameron
2025-05-05  9:58                 ` Karolina Stolarek
2025-05-05 17:45                   ` Bjorn Helgaas
2025-05-06 17:03                   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a92a75f-4348-4578-9b61-45682edaa514@oracle.com \
    --to=karolina.stolarek@oracle.com \
    --cc=Benjamin.Cheatham@amd.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=darren@os.amperecomputing.com \
    --cc=helgaas@kernel.org \
    --cc=ira.weiny@intel.com \
    --cc=james.morse@arm.com \
    --cc=lenb@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=liuxp11@chinatelecom.cn \
    --cc=pandoh@google.com \
    --cc=terry.bowman@amd.com \
    --cc=tony.luck@intel.com \
    --cc=xueshuai@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox