From: Damien Le Moal <dlemoal@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
Niklas Cassel <cassel@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-ide@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 1/2] ata: pata_cs5520: Remove not needed call to pci_enable_device_io
Date: Mon, 25 Mar 2024 16:57:34 +0900 [thread overview]
Message-ID: <5ae1b76b-03fa-433b-8d5a-62cc985cac42@kernel.org> (raw)
In-Reply-To: <5068d0ce-2140-4d3f-b305-e8f0d61eed1f@gmail.com>
On 3/24/24 02:14, Heiner Kallweit wrote:
> A few lines earlier pcim_enable_device() is called, which includes
> the functionality of pci_enable_device_io(). Therefore we can safely
> remove the call to pci_enable_device_io().
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Looks OK to me.
Acked-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-03-25 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 17:13 [PATCH 0/2] PCI: Remove pci_enable_device_io() Heiner Kallweit
2024-03-23 17:14 ` [PATCH 1/2] ata: pata_cs5520: Remove not needed call to pci_enable_device_io Heiner Kallweit
2024-03-23 17:43 ` Sergey Shtylyov
2024-03-25 7:57 ` Damien Le Moal [this message]
2024-03-23 17:16 ` [PATCH 2/2] PCI: Remove pci_enable_device_io() Heiner Kallweit
2024-03-25 7:58 ` Damien Le Moal
2024-03-28 22:13 ` [PATCH 0/2] " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ae1b76b-03fa-433b-8d5a-62cc985cac42@kernel.org \
--to=dlemoal@kernel.org \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox