From: Ray Jui <ray.jui@broadcom.com>
To: Abylay Ospan <aospan@netup.ru>,
Bjorn Helgaas <bhelgaas@google.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: iproc: fix kernel crash if dev->of_node not defined
Date: Thu, 12 Jan 2017 16:45:49 -0800 [thread overview]
Message-ID: <5c51f96f-1c49-3768-d3ef-1deb40bef713@broadcom.com> (raw)
In-Reply-To: <1484266817-6725-1-git-send-email-aospan@netup.ru>
On 1/12/2017 4:20 PM, Abylay Ospan wrote:
> pcie->dev->of_node not always defined (NULL) and can cause crash:
Ah I guess this can happen with the BCMA based platforms that do not use
device tree for PCIe?
>
> [ 19.053195] Unable to handle kernel NULL pointer dereference at
> virtual address 00000020
> [<c0b0370c>] (of_n_addr_cells) from [<c06599c4>]
> (iproc_pcie_setup+0x30c/0xce0)
>
> this patch adds sanity check to prevent crash.
>
> Signed-off-by: Abylay Ospan <aospan@netup.ru>
> ---
> drivers/pci/host/pcie-iproc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c
> index 3ebc025..f2836a9 100644
> --- a/drivers/pci/host/pcie-iproc.c
> +++ b/drivers/pci/host/pcie-iproc.c
> @@ -952,6 +952,9 @@ static int pci_dma_range_parser_init(struct of_pci_range_parser *parser,
> const int na = 3, ns = 2;
> int rlen;
>
> + if (!node)
> + return -ENOENT;
> +
Looks like a valid check to me.
Acked-by: Ray Jui <ray.jui@broadcom.com>
> parser->node = node;
> parser->pna = of_n_addr_cells(node);
> parser->np = parser->pna + na + ns;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-01-13 0:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 0:20 [PATCH] PCI: iproc: fix kernel crash if dev->of_node not defined Abylay Ospan
2017-01-13 0:22 ` Florian Fainelli
2017-01-13 0:48 ` Ray Jui
2017-01-13 1:20 ` Florian Fainelli
2017-01-13 4:55 ` Abylay Ospan
2017-01-16 22:47 ` Florian Fainelli
2017-01-13 5:58 ` Abylay Ospan
2017-01-13 0:45 ` Ray Jui [this message]
2017-01-28 20:44 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c51f96f-1c49-3768-d3ef-1deb40bef713@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=aospan@netup.ru \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox