Re: [PATCH 2/2] PCI: Disable ATS for specific Intel IPU E2000 devices

[Bartosz Pawlowski <bartosz.pawlowski@intel.com>]

On 17.08.2023 11:52, Andy Shevchenko wrote:
> On Wed, Aug 16, 2023 at 12:39:06PM -0500, Bjorn Helgaas wrote:
>> On Wed, Aug 16, 2023 at 05:21:15PM +0000, Bartosz Pawlowski wrote:
>>> There is a HW issue in A and B steppings of Intel IPU E2000 that it
>>> expects wrong endianness in ATS invalidation message body. This problem
>>> can lead to outdated translations being returned as valid and finally
>>> cause system instability.
>>>
>>> In order to prevent such issues introduce quirk_intel_e2000_no_ats()
>>> function to disable ATS for vulnerable IPU E2000 devices.
>>>
>>> Signed-off-by: Bartosz Pawlowski <bartosz.pawlowski@intel.com>
>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
>> Andy, Alexander, would you please reiterate your reviewed-by on the
>> mailing list?  I try to avoid relying on internal reviews collected by
>> the author.  Those are great and I'm glad they happen, but it's good
>> if they also appear as part of the public conversation on the mailing
>> list.
> They are legit for my name, I dunno what exactly you want to hear from me.
> The internal process of review requires these tags by default, it's hard
> to deviate from maintainer to maintainer.
>
>>> Intel Technology Poland sp. z o.o.
>>> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
>>> Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.
>>>
>>> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
>>> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
> What really needs to be dropped is the footer.
> Bartosz, consult with the internal resources on how to get rid of it.
Requested already and I hope it won't appear anymore.