From: Marek Vasut <marek.vasut@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Wolfram Sang <wsa@the-dreams.de>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] PCI: rcar: Always allocate MSI addresses in 32bit space
Date: Sun, 25 Oct 2020 16:37:13 +0100 [thread overview]
Message-ID: <5f056161-8adc-384f-9b60-842d9d7a3e8f@gmail.com> (raw)
In-Reply-To: <CAMuHMdW3obrfdnt7=oTxrpav2+rXhNhDiJ3fWRP3aF0jZQYNNQ@mail.gmail.com>
On 10/20/20 9:47 AM, Geert Uytterhoeven wrote:
> Hi Marek,
Hi,
[...]
>> --- a/drivers/pci/controller/pcie-rcar-host.c
>> +++ b/drivers/pci/controller/pcie-rcar-host.c
>> @@ -753,7 +753,7 @@ static int rcar_pcie_enable_msi(struct rcar_pcie_host *host)
>> }
>>
>> /* setup MSI data target */
>> - msi->pages = __get_free_pages(GFP_KERNEL, 0);
>> + msi->pages = __get_free_pages(GFP_KERNEL | GFP_DMA32, 0);
>
> BTW, can this fail, especially now this is allocated from a more
> limited pool?
I am pretty sure this can fail on systems that don't have DRAM below 4
GiB , but that is never the case on any hardware with this controller.
[...]
next prev parent reply other threads:[~2020-10-25 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 12:04 [PATCH] PCI: rcar: Always allocate MSI addresses in 32bit space marek.vasut
2020-10-20 7:47 ` Geert Uytterhoeven
2020-10-25 15:37 ` Marek Vasut [this message]
2020-10-27 12:04 ` Yoshihiro Shimoda
2020-12-10 18:11 ` Lorenzo Pieralisi
2020-12-12 19:13 ` Marek Vasut
2020-12-14 16:08 ` Lorenzo Pieralisi
2020-12-16 17:49 ` Marek Vasut
2020-12-21 10:01 ` Lorenzo Pieralisi
2020-12-30 12:47 ` Marek Vasut
2021-01-04 12:21 ` Lorenzo Pieralisi
2021-01-15 12:12 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f056161-8adc-384f-9b60-842d9d7a3e8f@gmail.com \
--to=marek.vasut@gmail.com \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).