Re: [PATCH] PCI: rcar-ep: Fix the issue of the name parameter when calling devm_request_mem_region

[Sergey Shtylyov <s.shtylyov@omp.ru>]

On 1/4/25 6:39 AM, kingdix10@qq.com wrote:

> From: King Dix <kingdix10@qq.com>
> 
> When using devm_request_mem_region to request a resource, if the passed
> variable is a stack string variable, it will lead to an oops issue when
> eecuting the command cat /proc/iomem.
> 
> Fix this by replacing outbound_name with the name of the previously
> requested resource.
> 
> Signed-off-by: King Dix <kingdix10@qq.com>
> ---
>  drivers/pci/controller/pcie-rcar-ep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
> index 047e2cef5afc..464f8f29390c 100644
> --- a/drivers/pci/controller/pcie-rcar-ep.c
> +++ b/drivers/pci/controller/pcie-rcar-ep.c
> @@ -107,7 +107,7 @@ static int rcar_pcie_parse_outbound_ranges(struct rcar_pcie_endpoint *ep,
>  		}
>  		if (!devm_request_mem_region(&pdev->dev, res->start,
>  					     resource_size(res),
> -					     outbound_name)) {
> +						 res->name)) {

   Why this strange indentation?

[...]

MBR, Sergey