Re: [PATCH 1/6] dt-bindings: pci: cadence: Add property "hpa" for PCIe controllers

[Krzysztof Kozlowski <krzk@kernel.org>]

On 24/03/2025 10:08, Manikandan Karunakaran Pillai wrote:
> Document the newly added property "hpa" for Cadence PCIe controllers in Documentation/devicetree/bindings/pci/ for Root Port and Endpoint configurations

Drop the path, pointless.

> 

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>

> Signed-off-by: Manikandan K Pillai <mpillai@cadence.com>
> ---
>  .../devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml         | 4 ++++
>  .../devicetree/bindings/pci/cdns,cdns-pcie-host.yaml       | 7 +++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> index 98651ab22103..4e839fa90b23 100644
> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> @@ -24,6 +24,10 @@ properties:
>        - const: reg
>        - const: mem
>  
> +  hpa:
> +    description: If present PCI controller is high performance architecture

compatible defines this.

> +    type: boolean
> +
>  required:
>    - reg
>    - reg-names
> diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
> index a8190d9b100f..c219fe15c879 100644
> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
> @@ -9,8 +9,11 @@ title: Cadence PCIe host controller
>  maintainers:
>    - Tom Joseph <tjoseph@cadence.com>
>  
> +select: false

No clue what you wanted to achieve here, no explanation in commit msg
and this makes not much sense.

> +
>  allOf:
>    - $ref: cdns-pcie-host.yaml#
> +  - $ref: cdns-pcie.yaml#

Why?

>  
>  properties:
>    compatible:
> @@ -24,6 +27,10 @@ properties:
>        - const: reg
>        - const: cfg
>  
> +  hpa:

Again, compatible defines this.

Anyway, follow standard DT binding rules (see writing bindings, numerous
talks or guides).

Best regards,
Krzysztof