From: Thomas Witt <thomas@witt.link>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Vidya Sagar <vidyas@nvidia.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Michael Bottini <michael.a.bottini@linux.intel.com>,
"David E . Box" <david.e.box@linux.intel.com>,
Tasev Nikola <tasev.stefanoska@skynet.be>,
Mark Enriquez <enriquezmark36@gmail.com>,
Thomas Witt <kernel@witt.link>, Koba Ko <koba.ko@canonical.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/ASPM: Add back L1 PM Substate save and restore
Date: Tue, 27 Jun 2023 11:53:33 +0200 [thread overview]
Message-ID: <61224a0b-ddf7-8348-332c-ec20e7d970e4@witt.link> (raw)
In-Reply-To: <20230627062442.54008-1-mika.westerberg@linux.intel.com>
On 27/06/2023 08:24, Mika Westerberg wrote:
> Commit a7152be79b62 ("Revert "PCI/ASPM: Save L1 PM Substates Capability
> for suspend/resume"") reverted saving and restoring of ASPM L1 Substates
> due to a regression that caused resume from suspend to fail on certain
> systems. However, we never added this capability back and this is now
> causing systems fail to enter low power CPU states, drawing more power
> from the battery.
Hello Mika,
I am sorry, but your patch (applied on top of master) triggers the exact
same behaviour I described in
<https://bugzilla.kernel.org/show_bug.cgi?id=216877> (nvme and wifi
become unavailable during suspend/resume)
Best Regards,
Thomas
next prev parent reply other threads:[~2023-06-27 10:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 6:24 [PATCH] PCI/ASPM: Add back L1 PM Substate save and restore Mika Westerberg
2023-06-27 9:53 ` Thomas Witt [this message]
2023-06-27 10:04 ` Mika Westerberg
2023-06-27 20:41 ` Bjorn Helgaas
2023-06-28 6:46 ` Mika Westerberg
2023-06-28 10:24 ` Thomas Witt
2023-06-28 10:59 ` Mika Westerberg
2023-06-28 12:30 ` Mika Westerberg
2023-06-29 9:47 ` Thomas Witt
2023-06-29 10:23 ` Mika Westerberg
2023-06-29 14:24 ` David E. Box
2023-06-30 10:41 ` Mika Westerberg
2023-06-30 16:58 ` Thomas Witt
2023-07-05 20:53 ` David E. Box
2023-07-06 19:14 ` Thomas Witt
2023-07-31 15:01 ` Mika Westerberg
2023-08-05 7:57 ` Thomas Witt
2023-08-07 7:58 ` Mika Westerberg
2023-08-10 23:44 ` David E. Box
2023-06-28 12:16 ` Mario Limonciello
2023-06-28 12:38 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61224a0b-ddf7-8348-332c-ec20e7d970e4@witt.link \
--to=thomas@witt.link \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=enriquezmark36@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=kernel@witt.link \
--cc=koba.ko@canonical.com \
--cc=linux-pci@vger.kernel.org \
--cc=michael.a.bottini@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tasev.stefanoska@skynet.be \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).