linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramon Fried <ramon.fried@gmail.com>
To: Alan Douglas <adouglas@cadence.com>, bhelgaas@google.com
Cc: kishon@ti.com, lorenzo.pieralisi@arm.com,
	linux-pci@vger.kernel.org, gustavo.pimentel@synopsys.com,
	cyrille.pitchen@bootlin.com, stelford@cadence.com
Subject: Re: [PATCH v2 0/5] Add MSI-X support for cadence EP driver
Date: Wed, 15 Aug 2018 19:55:45 +0300	[thread overview]
Message-ID: <615023FB-D8BA-4F12-BC2B-EDDBBDA39148@gmail.com> (raw)
In-Reply-To: <1534340781-19194-1-git-send-email-adouglas@cadence.com>

On August 15, 2018 4:46:21 PM GMT+03:00, Alan Douglas <adouglas@cadence=2Ec=
om> wrote:
>The patch implements MSI-X support in the cadence endpoint driver=2E
>
>This patch depends on on Gustavo Pimentel's patch series adding MSI-X
>support for EP ("Add MSI-X support on pcitest tool")=20
>
>It also adds fixes for MSI issues discovered during testing of MSI-X
>  - Use AXI region 0 for interrupt signalling
>  - Write MSI and MSI-X with 32bit value rather than 16bit
>  - Check for masking before sending MSI or MSI-X
>  - Check link is up before sending IRQ
>
Hi=2E=20
AFAIK the BIOS allocates physical memory for the bars=2E Assuming that the=
 MSIx bar is only mapped after kernel boots on the endpoint, could it be to=
o late?=20

Do we need to trigger re-enumeration of the PCI bus from host side when wo=
rking with this as an endpoint?=20

Thanks,=20
Ramon=20
>Changes since v1:
>  - Rebased on 4=2E18-rc1
>  - Update commit log to mark first 4 patches as fixes
>  - Correct formatting issues pointed out by checkpatch --strict
>
>Alan Douglas (5):
>  PCI: cadence: Use AXI region 0 to signal interrupts from EP
>  PCI: cadence: Write MSI data with 32bits
>  PCI: cadence: Check whether MSI is masked before sending it
>  PCI: cadence: Check link is up before sending IRQ from EP
>  PCI: cadence: Add MSI-X capability to EP driver
>
>drivers/pci/controller/pcie-cadence-ep=2Ec | 131
>+++++++++++++++++++++++++++++--
> drivers/pci/controller/pcie-cadence=2Eh    |   1 +
> 2 files changed, 125 insertions(+), 7 deletions(-)


--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E

  reply	other threads:[~2018-08-15 19:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15 13:46 [PATCH v2 0/5] Add MSI-X support for cadence EP driver Alan Douglas
2018-08-15 16:55 ` Ramon Fried [this message]
2018-08-16 14:28   ` Alan Douglas
     [not found]     ` <CA+Kvs9m=jECCcy6RCrtKvJOAwt5Fr8XFFkkijMy3MFe9trav5g@mail.gmail.com>
2018-08-17  4:09       ` Ramon Fried
2018-08-17  8:32         ` Alan Douglas
2018-08-17  8:52           ` Ramon Fried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=615023FB-D8BA-4F12-BC2B-EDDBBDA39148@gmail.com \
    --to=ramon.fried@gmail.com \
    --cc=adouglas@cadence.com \
    --cc=bhelgaas@google.com \
    --cc=cyrille.pitchen@bootlin.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=kishon@ti.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=stelford@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).