From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Qiang Yu" <qiang.yu@oss.qualcomm.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Bjorn Andersson" <andersson@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, Qiang Yu <quic_qianyu@quicinc.com>
Subject: Re: [PATCH v5 2/6] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the Glymur QMP PCIe Gen4 2-lane PHY
Date: Sun, 19 Oct 2025 11:07:22 +0200 [thread overview]
Message-ID: <63776d93-a766-4fcb-a69b-96b24832eb1b@kernel.org> (raw)
In-Reply-To: <20251017-glymur_pcie-v5-2-82d0c4bd402b@oss.qualcomm.com>
On 18/10/2025 03:33, Qiang Yu wrote:
> From: Qiang Yu <quic_qianyu@quicinc.com>
>
> The 4th and 6th PCIe instances on Glymur have Gen4 2-lane PHY. Document it
> as a separate compatible.
>
> Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 3 +++
Nothing in the changelog explains that this patch appeared. Write
descriptive changelogs explaining what is happening with the patches.
This should be squashed with previous one, it's really pointless to add
same device - PCI PHY - in multiple steps, just because there are
different lanes.
Add complete PCI PHY - ALL OF THEM - at once.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-19 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 1:33 [PATCH v5 0/6] PCI: qcom: Add support for Glymur PCIe Gen5 x4 and Gen4 x2 Qiang Yu
2025-10-18 1:33 ` [PATCH v5 1/6] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the Glymur QMP PCIe PHY Qiang Yu
2025-10-18 1:33 ` [PATCH v5 2/6] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the Glymur QMP PCIe Gen4 2-lane PHY Qiang Yu
2025-10-19 9:07 ` Krzysztof Kozlowski [this message]
2025-10-21 7:04 ` Krzysztof Kozlowski
2025-10-22 9:05 ` Qiang Yu
2025-10-18 1:33 ` [PATCH v5 3/6] dt-bindings: PCI: qcom: Document the Glymur PCIe Controller Qiang Yu
2025-10-18 1:33 ` [PATCH v5 4/6] phy: qcom-qmp: pcs: Add v8.50 register offsets Qiang Yu
2025-10-18 1:33 ` [PATCH v5 5/6] phy: qcom: qmp-pcie: Add support for Glymur PCIe Gen5x4 PHY Qiang Yu
2025-10-18 1:33 ` [PATCH v5 6/6] phy: qcom: qmp-pcie: Add support for glymur PCIe Gen4 x2 PHY Qiang Yu
2025-10-22 8:53 ` Abel Vesa
2025-10-22 9:01 ` Qiang Yu
2025-10-31 8:20 ` (subset) [PATCH v5 0/6] PCI: qcom: Add support for Glymur PCIe Gen5 x4 and Gen4 x2 Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63776d93-a766-4fcb-a69b-96b24832eb1b@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=qiang.yu@oss.qualcomm.com \
--cc=quic_qianyu@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox