From: Dan Williams <dan.j.williams@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, <linux-pci@vger.kernel.org>
Cc: "Dan J Williams" <dan.j.williams@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Tony Luck" <tony.luck@intel.com>,
"David E Box" <david.e.box@intel.com>,
"Yunying Sun" <yunying.sun@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Giovanni Cabiddu" <giovanni.cabiddu@intel.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Hans de Goede" <hdegoede@redhat.com>,
"Florent DELAHAYE" <linuxkernelml@undead.fr>,
"Konrad J Hambrick" <kjhambrick@gmail.com>,
"Matt Hansen" <2lprbe78@duck.com>,
"Nicholas Johnson" <nicholas.johnson-opensource@outlook.com.au>,
"Benoit Grégoire" <benoitg@coeus.ca>,
"Werner Sembach" <wse@tuxedocomputers.com>,
mumblingdrunkard@protonmail.com, linux-kernel@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: RE: [PATCH 1/2] x86/pci: Simplify is_mmconf_reserved() messages
Date: Tue, 10 Jan 2023 10:07:39 -0800 [thread overview]
Message-ID: <63bda96bcb95c_5178e29418@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20230110180243.1590045-2-helgaas@kernel.org>
Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> is_mmconf_reserved() takes a "with_e820" parameter that only determines the
> message logged if it finds the MMCONFIG region is reserved. Pass the
> message directly, which will simplify a future patch that adds a new way of
> looking for that reservation. No functional change intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> arch/x86/pci/mmconfig-shared.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
> index 758cbfe55daa..cd16bef5f2d9 100644
> --- a/arch/x86/pci/mmconfig-shared.c
> +++ b/arch/x86/pci/mmconfig-shared.c
> @@ -446,13 +446,12 @@ typedef bool (*check_reserved_t)(u64 start, u64 end, enum e820_type type);
>
> static bool __ref is_mmconf_reserved(check_reserved_t is_reserved,
> struct pci_mmcfg_region *cfg,
> - struct device *dev, int with_e820)
> + struct device *dev, char *method)
@method could be 'const char *', but either way:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2023-01-10 18:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 18:02 [PATCH 0/2] PCI: Fix extended config space regression Bjorn Helgaas
2023-01-10 18:02 ` [PATCH 1/2] x86/pci: Simplify is_mmconf_reserved() messages Bjorn Helgaas
2023-01-10 18:07 ` Dan Williams [this message]
2023-01-10 18:12 ` Bjorn Helgaas
2023-01-10 18:02 ` [PATCH 2/2] x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM space Bjorn Helgaas
2023-01-10 18:15 ` Rafael J. Wysocki
2023-01-10 18:29 ` Dan Williams
2023-01-10 19:30 ` Bjorn Helgaas
2023-10-12 15:33 ` Tomasz Pala
2023-10-16 17:31 ` Tomasz Pala
2023-10-26 20:53 ` Bjorn Helgaas
2023-11-03 19:18 ` Bjorn Helgaas
2023-11-09 18:44 ` Bjorn Helgaas
2023-11-18 14:21 ` Tomasz Pala
2023-11-20 16:29 ` Bjorn Helgaas
2023-11-21 15:24 ` Tomasz Pala
2023-11-21 18:19 ` Bjorn Helgaas
2023-11-08 17:47 ` Bjorn Helgaas
2023-11-08 20:20 ` Bjorn Helgaas
2023-12-06 11:54 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-01-10 20:38 ` [PATCH 0/2] PCI: Fix extended config space regression Liang, Kan
2023-01-10 22:57 ` Luck, Tony
2023-01-11 12:10 ` Giovanni Cabiddu
2023-01-11 22:30 ` Bjorn Helgaas
2023-01-12 5:50 ` Sun, Yunying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63bda96bcb95c_5178e29418@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=2lprbe78@duck.com \
--cc=benoitg@coeus.ca \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=david.e.box@intel.com \
--cc=giovanni.cabiddu@intel.com \
--cc=hdegoede@redhat.com \
--cc=helgaas@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kan.liang@linux.intel.com \
--cc=kjhambrick@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxkernelml@undead.fr \
--cc=mika.westerberg@linux.intel.com \
--cc=mumblingdrunkard@protonmail.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=tony.luck@intel.com \
--cc=wse@tuxedocomputers.com \
--cc=yunying.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).