linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>, <helgaas@kernel.org>
Cc: <linux-pci@vger.kernel.org>, <stuart.w.hayes@gmail.com>,
	<dan.j.williams@intel.com>
Subject: Re: [PATCH 0/3] Enclosure sysfs refactor
Date: Thu, 4 May 2023 10:16:36 -0700	[thread overview]
Message-ID: <6453e874d1c0e_2ec5d2945f@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20230504141048.00001ba6@linux.intel.com>

Mariusz Tkaczyk wrote:
> On Thu, 17 Nov 2022 17:34:04 +0100
> Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote:
> 
> > Hi Bjorn,
> > I agreed with Stuart to take over the NPEM implementation[1].
> > First part I want to share is a small refactor around enclosure interface.
> > 
> > The one sysfs change introduced is changing active LED to write-only.
> > get_active() callback is not implemented for SES which is the
> > only one enclosure API consumer now.
> > 
> > [1]
> > https://lore.kernel.org/linux-pci/cover.1643822289.git.stuart.w.hayes@gmail.com/
> > 
> > Mariusz Tkaczyk (3):
> >   misc: enclosure: remove get_active() callback
> >   misc: enclosure, ses: simplify some get callbacks
> >   misc: enclosure: update sysfs api
> > 
> >  drivers/misc/enclosure.c  | 96 ++++++++++++++++-----------------------
> >  drivers/scsi/ses.c        | 33 ++++++++------
> >  include/linux/enclosure.h | 14 ++----
> >  3 files changed, 61 insertions(+), 82 deletions(-)
> > 
> 
> Hi Bjorn,
> Could you please take a look? Let me know if you against this cleanup.
> I would like to get back to NPEM, I based my patches on top of it.

Hi Mariusz,

I don't expect Bjorn to handle enclosure updates. I expect the upstream
path for these patches is through the SCSI tree. Going forward you can
use get_maintainer.pl for this routing information.

$ ./scripts/get_maintainer.pl drivers/scsi/ses.c 
"James E.J. Bottomley" <jejb@linux.ibm.com> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
linux-scsi@vger.kernel.org (open list:SCSI SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

I'll take a look and then you can resend to linux-scsi. I do like this
stat line:

3 files changed, 61 insertions(+), 82 deletions(-)

...makes it compelling to take a look.

  reply	other threads:[~2023-05-04 17:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 16:34 [PATCH 0/3] Enclosure sysfs refactor Mariusz Tkaczyk
2022-11-17 16:34 ` [PATCH 1/3] misc: enclosure: remove get_active() callback Mariusz Tkaczyk
2023-05-04 17:22   ` Dan Williams
2022-11-17 16:34 ` [PATCH 2/3] misc: enclosure, ses: simplify some get callbacks Mariusz Tkaczyk
2023-05-04 23:58   ` Dan Williams
2023-05-05 11:45     ` Mariusz Tkaczyk
2023-05-05 17:33       ` Dan Williams
2022-11-17 16:34 ` [PATCH 3/3] misc: enclosure: update sysfs api Mariusz Tkaczyk
2023-05-05  0:11   ` Dan Williams
2023-05-04 12:10 ` [PATCH 0/3] Enclosure sysfs refactor Mariusz Tkaczyk
2023-05-04 17:16   ` Dan Williams [this message]
2023-05-05  9:12     ` Mariusz Tkaczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6453e874d1c0e_2ec5d2945f@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mariusz.tkaczyk@linux.intel.com \
    --cc=stuart.w.hayes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).