From: Dan Williams <dan.j.williams@intel.com>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-cxl@vger.kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>, <oohall@gmail.com>,
Lukas Wunner <lukas@wunner.de>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
"Alison Schofield" <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
Terry Bowman <terry.bowman@amd.com>,
Robert Richter <rrichter@amd.com>
Subject: Re: [PATCH v2 1/3] cxl/pci: Fix appropriate checking for _OSC while handling CXL RAS registers
Date: Mon, 7 Aug 2023 20:22:19 -0700 [thread overview]
Message-ID: <64d1b4eb4d991_5ea6e29427@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <64da6d98-953f-f813-7184-e69b1c8bb28e@amd.com>
Smita Koralahalli wrote:
>
> >> - /* BIOS has CXL error control */
> >> - if (!host_bridge->native_cxl_error)
> >> - return -ENXIO;
> >> + /* BIOS has PCIe AER error control */
> >> + if (!host_bridge->native_aer)
> >> + return 0;
> >
> > Why not directly use pcie_aer_is_native() here?
> Yeah, this was in my v1. But changed as per Robert's comments, to be
> applicable for automated backports..
>
> https://lore.kernel.org/all/ZLkxiZv3lWfazwVH@rric.localdomain/
>
> Please advice.
Keep it the way you have it. Minimizing the backport is the right call.
next prev parent reply other threads:[~2023-08-08 3:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 21:47 [PATCH v2 0/3] PCI/AER, CXL: Fix appropriate _OSC check for CXL RAS Cap Smita Koralahalli
2023-07-21 21:47 ` [PATCH v2 1/3] cxl/pci: Fix appropriate checking for _OSC while handling CXL RAS registers Smita Koralahalli
2023-07-22 0:18 ` Sathyanarayanan Kuppuswamy
2023-07-24 21:59 ` Smita Koralahalli
2023-08-08 3:22 ` Dan Williams [this message]
2023-07-24 12:02 ` Robert Richter
2023-08-08 3:17 ` Dan Williams
2023-08-08 19:37 ` Smita Koralahalli
2023-07-21 21:47 ` [PATCH v2 2/3] PCI/AER: Export pcie_aer_is_native() Smita Koralahalli
2023-07-24 12:42 ` Robert Richter
2023-08-08 3:20 ` Dan Williams
2023-07-21 21:47 ` [PATCH v2 3/3] cxl/pci: Replace host_bridge->native_aer with pcie_aer_is_native() Smita Koralahalli
2023-07-22 0:17 ` Sathyanarayanan Kuppuswamy
2023-07-24 12:44 ` Robert Richter
2023-08-08 3:21 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64d1b4eb4d991_5ea6e29427@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=alison.schofield@intel.com \
--cc=bhelgaas@google.com \
--cc=bwidawsk@kernel.org \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=rrichter@amd.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=terry.bowman@amd.com \
--cc=vishal.l.verma@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).