Re: [PATCH] PCI/ASPM: Add back L1 PM Substate save and restore

["David E. Box" <david.e.box@linux.intel.com>]

On Mon, 2023-08-07 at 10:58 +0300, Mika Westerberg wrote:
> Hi Thomas,
> 
> On Sat, Aug 05, 2023 at 09:57:47AM +0200, Thomas Witt wrote:
> > On 31/07/2023 17:01, Mika Westerberg wrote:
> > > Hi Thomas,
> > > 
> > > Thanks for trying that. Did you manage to try out the S0ix script David
> > > suggested? That should show us hopefully what is draining the battery in
> > > s2idle.
> > 
> > Hi Mika,
> > 
> > I did, with -s it gives
> > 
> > Your system does not support low power S0 idle capability.
> > Isolation suggestion:
> > Please check BIOS low power S0 idle capability setting.
> > 
> > with -r on
> > 
> > Your system did not achieve the runtime PC10 state during screen ON
> 
> Thanks for trying. Did you change the "mem_sleep" back to "s2idle"
> before you run the script?

The script checks the FADT to determine if the system supports S0ix and it found
that it didn't which is weird since Thomas is setting "mem_sleep" to "deep" from
the default "s2idle" which is based on this bit.

Here are the commands to check it.

  sudo acpidump -n FADT -b
  iasl -d facp.dat
  grep "Low Power S0 Idle" facp.dsl

Thomas, can you confirm what the value of mem_sleep is when you boot and run the
above to confirm what your hardware supports?

> 
> > additionally, it encounters a syntax error:
> > ./s0ix-selftest-tool.sh: line 1182: wc:: syntax error in expression (error
> > token is ":")
> 
> @David, do you know what might be the issue?

Yes. The latest kernel changes the output of the ltr_show command by adding a
PMC number prefix (since Meteor Lake has more than one PMC now). The script is
erring on the unexpected colon. We'll get this fixed.

David

> 
> > with -r off, it tries xset which fails due to a lack of xserver.
> 
> You do have graphics running right? I mean i915 driver is enabled and
> all the firmwares are in place (should come with the distro). I'm asking
> because s2idle typically requires that graphics and pretty much all the
> devices on the SoC have a driver and the accompanying firmwares, and
> that they enter D3 properly.