From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Arnd Bergmann To: Ley Foon Tan Cc: Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, lftan.linux@gmail.com Subject: Re: [PATCH 1/2] nios2: Add architectural support for PCIe Date: Tue, 22 Sep 2015 10:18:58 +0200 Message-ID: <65590637.5YmBIDOvTf@wuerfel> In-Reply-To: <1442906367-10935-2-git-send-email-lftan@altera.com> References: <1442906367-10935-1-git-send-email-lftan@altera.com> <1442906367-10935-2-git-send-email-lftan@altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-arch-owner@vger.kernel.org List-ID: On Tuesday 22 September 2015 15:19:26 Ley Foon Tan wrote: > + > +config PCI_SYSCALL > + def_bool PCI IIRC, PCI_SYSCALL is deprecated and you should just leave that turned off. In any case, you enable the syscalls here but don't assign a system call number, so that is rather pointless. I I might be missing something though. Bjorn? > @@ -14,7 +14,7 @@ > #include > #include > > -/* PCI is not supported in nios2, set this to 0. */ > +/* PCI I/O space is not supported, set this to 0. */ > #define IO_SPACE_LIMIT 0 > > #define readb_relaxed(addr) readb(addr) It might be useful to enable this, just in case someone connects a PCI host bridge that does support I/O space. Which host bridge do you use? Are you sure there is no I/O space? Most of them use a set of translation windows to set up a mapping between bus address (memory, config and io space) and physical (mmio) space. > diff --git a/arch/nios2/include/asm/pci.h b/arch/nios2/include/asm/pci.h > new file mode 100644 > index 0000000..f2cba05 > --- /dev/null > +++ b/arch/nios2/include/asm/pci.h What happens if you use the asm-generic header? If there is something missing in it, we can try to get it to do the right things. Arnd