Re: [PATCH] pci: xgene: Add ECAM fixups

Re: [PATCH] pci: xgene: Add ECAM fixups

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

Hi Duc,

[auto build test ERROR on pci/next]
[also build test ERROR on v4.5-rc3 next-20160209]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Duc-Dang/pci-xgene-Add-ECAM-fixups/20160210-095702
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: arm64-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

>> drivers/pci/host/pci-xgene.c:34:24: fatal error: linux/ecam.h: No such file or directory
    #include <linux/ecam.h>
                           ^
   compilation terminated.

vim +34 drivers/pci/host/pci-xgene.c

    28	#include <linux/of_pci.h>
    29	#include <linux/pci.h>
    30	#include <linux/platform_device.h>
    31	#include <linux/slab.h>
    32	#ifdef CONFIG_ACPI
    33	#include <linux/acpi.h>
  > 34	#include <linux/ecam.h>
    35	#include <linux/pci-acpi.h>
    36	#endif
    37	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 48147 bytes --]

Re: [PATCH] pci: xgene: Add ECAM fixups

[Arnd Bergmann]

On Tuesday 09 February 2016 17:49:44 Duc Dang wrote:
> X-Gene PCIe controller does not fully support ECAM.
> This patch adds required ECAM fixup to allow X-Gene
> PCIe controller to be functional in ACPI boot mode.
> 
> This patch is based on the original work of
> Mark Salter <msalter@redhat.com> and depends on
> Tomasz's PCIe ACPI series:
> https://lkml.org/lkml/2016/2/4/646
> 
> Signed-off-by: Duc Dang <dhdang@apm.com>
> ---

This really has nothing to do with the PCI host device driver, please
keep it in a separate file in drivers/acpi/.

	Arnd

Re: [PATCH] pci: xgene: Add ECAM fixups

[Duc Dang]

On Wed, Feb 10, 2016 at 6:28 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 09 February 2016 17:49:44 Duc Dang wrote:
>> X-Gene PCIe controller does not fully support ECAM.
>> This patch adds required ECAM fixup to allow X-Gene
>> PCIe controller to be functional in ACPI boot mode.
>>
>> This patch is based on the original work of
>> Mark Salter <msalter@redhat.com> and depends on
>> Tomasz's PCIe ACPI series:
>> https://lkml.org/lkml/2016/2/4/646
>>
>> Signed-off-by: Duc Dang <dhdang@apm.com>
>> ---
>
> This really has nothing to do with the PCI host device driver, please
> keep it in a separate file in drivers/acpi/.

Hi Arnd,

With Tomasz latest PCIe ACPI series
(https://lkml.org/lkml/2016/4/15/594), do you think it still better to
keep the ACPI ECAM fixup code in a separate file in drivers/acpi
directory?

Regards,
Duc Dang.

>
>         Arnd

Re: [PATCH] pci: xgene: Add ECAM fixups

[Arnd Bergmann]

On Friday 15 April 2016 14:30:56 Duc Dang wrote:
> On Wed, Feb 10, 2016 at 6:28 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Tuesday 09 February 2016 17:49:44 Duc Dang wrote:
> >> X-Gene PCIe controller does not fully support ECAM.
> >> This patch adds required ECAM fixup to allow X-Gene
> >> PCIe controller to be functional in ACPI boot mode.
> >>
> >> This patch is based on the original work of
> >> Mark Salter <msalter@redhat.com> and depends on
> >> Tomasz's PCIe ACPI series:
> >> https://lkml.org/lkml/2016/2/4/646
> >>
> >> Signed-off-by: Duc Dang <dhdang@apm.com>
> >> ---
> >
> > This really has nothing to do with the PCI host device driver, please
> > keep it in a separate file in drivers/acpi/.
> 
> Hi Arnd,
> 
> With Tomasz latest PCIe ACPI series
> (https://lkml.org/lkml/2016/4/15/594), do you think it still better to
> keep the ACPI ECAM fixup code in a separate file in drivers/acpi
> directory?

Yes, I made the same comment for the cavium PCI workaround in that
series.

	Arnd