From: Dan Williams <dan.j.williams@intel.com>
To: "Kobayashi,Daisuke" <kobayashi.da-06@fujitsu.com>,
<kobayashi.da-06@jp.fujitsu.com>, <linux-cxl@vger.kernel.org>
Cc: <y-goto@fujitsu.com>, <linux-pci@vger.kernel.org>, <mj@ucw.cz>,
<dan.j.williams@intel.com>,
"Kobayashi,Daisuke" <kobayashi.da-06@fujitsu.com>
Subject: Re: [PATCH v3 2/3] Remove conditional branch that is not suitable for cxl1.1 devices
Date: Tue, 26 Mar 2024 13:00:47 -0700 [thread overview]
Message-ID: <6603296f71d1f_4a98a294a2@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <20240312080559.14904-3-kobayashi.da-06@fujitsu.com>
Kobayashi,Daisuke wrote:
> This patch removes conditional branching that does not comply with the specifications.
>
> In the existing code, there is a conditional branch that compares "chbs->length"
> with "CXL_RCRB_SIZE". However, according to the specifications, "chbs->length"
> indicates the length of the CHBS structure in the cedt, not the size of the
> configuration space. Therefore, since this condition does not comply with
> the specifications(cxl3.0 specification 9.17.1), remove it.
No, in Table 9-21 in CXL 3.1:
Base: If CXL Version = 0000 0000h, this represents the base address of
the RCH Downstream Port RCRB
Length: If CXL Version = 0000 0000h, this field must be set to 8 KB
(2000h)
The size of the CHBS structure is always much less than 8KB.
next prev parent reply other threads:[~2024-03-26 20:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 8:05 [PATCH v3 0/3] Display cxl1.1 device link status Kobayashi,Daisuke
2024-03-12 8:05 ` [PATCH v3 1/3] Add sysfs attribute for CXL 1.1 " Kobayashi,Daisuke
2024-03-26 19:51 ` Dan Williams
2024-03-28 1:47 ` Daisuke Kobayashi (Fujitsu)
2024-04-03 9:40 ` Daisuke Kobayashi (Fujitsu)
2024-04-05 8:31 ` Daisuke Kobayashi (Fujitsu)
2024-04-08 21:43 ` Dan Williams
2024-04-09 4:55 ` Daisuke Kobayashi (Fujitsu)
2024-04-05 17:25 ` Jonathan Cameron
2024-04-08 21:32 ` Dan Williams
2024-04-09 14:59 ` Bjorn Helgaas
2024-04-09 15:00 ` Bjorn Helgaas
2024-03-12 8:05 ` [PATCH v3 2/3] Remove conditional branch that is not suitable for cxl1.1 devices Kobayashi,Daisuke
2024-03-26 20:00 ` Dan Williams [this message]
2024-03-27 8:26 ` Daisuke Kobayashi (Fujitsu)
2024-03-12 8:05 ` [PATCH v3 3/3] Add function to display cxl1.1 device link status Kobayashi,Daisuke
2024-03-26 20:05 ` Dan Williams
2024-03-27 8:27 ` Daisuke Kobayashi (Fujitsu)
2024-03-29 22:23 ` Martin Mareš
2024-03-30 1:15 ` Dan Williams
2024-03-31 1:03 ` Martin Mareš
2024-04-01 17:47 ` Dan Williams
2024-04-02 7:09 ` Daisuke Kobayashi (Fujitsu)
2024-03-25 4:49 ` [PATCH v3 0/3] Display " Daisuke Kobayashi (Fujitsu)
2024-03-26 19:15 ` Dan Williams
2024-03-27 8:24 ` Daisuke Kobayashi (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6603296f71d1f_4a98a294a2@dwillia2-mobl3.amr.corp.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=kobayashi.da-06@fujitsu.com \
--cc=kobayashi.da-06@jp.fujitsu.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mj@ucw.cz \
--cc=y-goto@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox