From: Sinan Kaya <okaya@codeaurora.org>
To: Don Brace <don.brace@microsemi.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"timur@codeaurora.org" <timur@codeaurora.org>,
"ryan@finnie.org" <ryan@finnie.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
Frederick Lawler <fred@fredlawl.com>,
Dongdong Liu <liudongdong3@huawei.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
"esc.storagedev" <esc.storagedev@microsemi.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown
Date: Mon, 28 May 2018 14:25:33 -0700 [thread overview]
Message-ID: <667a240c-9f83-181d-9aa3-f9ee3aa66272@codeaurora.org> (raw)
In-Reply-To: <36b790d3fb4c43349cfa560283c03ab5@microsemi.com>
On 5/24/2018 6:37 AM, Don Brace wrote:
>> But we really need guidance from an hpsa expert. I don't know the
>> filesystem/SCSI/hpsa details.
>>
>> Bjorn
> It's most likely OCSD traffic that will stop when bus mastering is turned off.
> So, I'll run some tests on my end before ACKing your patch.
Can you test V3 instead of this?
I don't think adding pci_disable_device() to shutdown() is enough to put
the HW into safe state. I moved clean up responsibility to remove() instead
of shutdown().
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-05-28 21:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 2:44 [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown Sinan Kaya
2018-05-23 21:32 ` Bjorn Helgaas
2018-05-23 22:57 ` Sinan Kaya
2018-05-24 11:43 ` Sinan Kaya
2018-05-24 13:07 ` Bjorn Helgaas
2018-05-24 13:35 ` okaya
2018-05-24 13:37 ` Don Brace
2018-05-28 21:25 ` Sinan Kaya [this message]
2018-05-24 18:35 ` Bjorn Helgaas
2018-05-25 13:30 ` Sinan Kaya
2018-05-25 22:10 ` Bjorn Helgaas
2018-05-25 22:34 ` okaya
2018-05-30 2:41 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667a240c-9f83-181d-9aa3-f9ee3aa66272@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=fred@fredlawl.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ryan@finnie.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).