From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11C0D47F4D; Tue, 6 Aug 2024 19:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722972126; cv=fail; b=LoqBibv+kkSfll7YDxbfQNOcLdAi5z6ES9qg2yZXDE9m5A8QBC+Mez1vnbmB5DIEb7iSenhbMfbVVzy2jFu2hvye2+Qe5UenVopTkKKY8bbzga2a4kfvfIFGXenDG1EVCfpGai9oK7ky2rJQJlPopcFVVsSSLNSQ3j55FJPTZhI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722972126; c=relaxed/simple; bh=AUMs3IX5x4G0WUUmJkQK5+pCE5e0C8e+M1MyqlXq11U=; h=Date:From:To:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=LN4H+YBYlzUpVOMtBI8eJH3F0hctzgQWbCOI++UkVH8+nZI2tqyVr+rKkIzQAdRyooKsjbz9cpudQAwpgq288OO1GDF+bLZfdtr59zY2+sdlswRxhcxl0SsJEVeBjfvd0Q3caMqN+JFfaIE7pa7cLuWXnNvmv6fVILTRV6AHYTI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CQdpH0XR; arc=fail smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CQdpH0XR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722972124; x=1754508124; h=date:from:to:subject:message-id:references:in-reply-to: mime-version; bh=AUMs3IX5x4G0WUUmJkQK5+pCE5e0C8e+M1MyqlXq11U=; b=CQdpH0XR6wSy4buNW8j40WLz0TzPZkNzovoRWowIkaDSpMoWsuEQobbx nTQEftXl8Riibe7dRa0MITh0CwTYtv5rxgVa4bu0PEPwyKJIwdP8LMpSu lshWJs1oKRqVmjueZTNZcWzTUFy7X/PMq/ntta6o08tloYxkTCIIrDefM 8hMZqh/vzd1wI8FkF0LM4Wkci89MVm4Zl+cDnN4RVENs8vQyBmZiPQgD5 MLUOlU+s4ADDBem3LnqsctqGrXyhBZYY5dbGKz2tz83vIbDyzlz5HUlpz 395lvwY5aQBsOyRORNXZbcEYVuY2yeWgwEg/QrQIRrh7X6WwuKp5ueevA Q==; X-CSE-ConnectionGUID: Q2smx1UTQy+QjGSFP6jLGw== X-CSE-MsgGUID: CcgccJCaRiyQ2abjrr4ncg== X-IronPort-AV: E=McAfee;i="6700,10204,11156"; a="24779221" X-IronPort-AV: E=Sophos;i="6.09,268,1716274800"; d="scan'208";a="24779221" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2024 12:22:02 -0700 X-CSE-ConnectionGUID: 3SwlQ9ZXQYS2urGVJleTSg== X-CSE-MsgGUID: VAqaaWHlQrKUetCzT6BmuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,268,1716274800"; d="scan'208";a="79864109" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Aug 2024 12:22:03 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 6 Aug 2024 12:22:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 6 Aug 2024 12:22:01 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 6 Aug 2024 12:22:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Gt/dH4jIGIpxyaLM3Xp1uL78dl1l3yA/YiWB/fv1A45CkSQrz+ehc9CD3sWbxLxYN/ng/tGORFVeFMwwhO9Pey25qTwWpGnBZNr/GMLUKMrfxDEgFe4V+7p8p5CDbH2C4yu0GrwxKx6cRrIMs++Qo6jXorJZe13HBBLQk10afxmAH8hJ1axIxS8A/l9VE6gBNyAk5u9ykYnnMSunqDj0C22ffwt6w9ynheSVKabe/AN7MaQIJK2D08Nmj/pQwc5FPtpMq0f+ExK4v15Ugh/ScUv1jhqQ/6IGlv5lPRI75eSQREXx5aNtfPxqvq5zaGseq7lM1W8AXeevNPQILEPTWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hq7S1d28daJr+c06oBR5PZZBP0zl9lGti3eVKRqWqco=; b=H5UVaZGDIzcE5CuVlSG8LRmoY8v04L1TNUZWDnZPszKuL9LebEPbPtv1RmYNeK+JIuRYOoi1TfXuJK8zSJ7Y/E2ODm2MPyu6pmyF5akoSl2DNUxf4Wm2GZelBtyYEpi65OknPbe94IYDHbimBZdZVGoF/SLBHPi6xs50yAfo5oSzejblbSc1kiHXdwBUVtj8BfH3xx/KTFUA2z+dHO8PijItj5DIGqruUn3twaiwJxdHxDCDlE9tpIr5oUsZV2WIJTBo3pvinBOXYV81iWcjYTykprzwEzbM49sSWJQZeGyaU3yWGaVQwyZ2YKIhtGm5ptkWHqZmeCm7xv1L+SlqXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by SA1PR11MB6616.namprd11.prod.outlook.com (2603:10b6:806:257::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.23; Tue, 6 Aug 2024 19:21:59 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8%4]) with mapi id 15.20.7828.021; Tue, 6 Aug 2024 19:21:58 +0000 Date: Tue, 6 Aug 2024 12:21:56 -0700 From: Dan Williams To: "Fabio M. De Francesco" , "Rafael J. Wysocki" , Len Brown , "Mahesh J Salgaonkar" , Oliver O'Halloran , Bjorn Helgaas , , , , , Dan Williams Subject: Re: [PATCH 1/2] ACPI: extlog: Trace CPER Non-standard Section Body Message-ID: <66b277d4ed6f_c144829421@dwillia2-xfh.jf.intel.com.notmuch> References: <20240527144356.246220-1-fabio.m.de.francesco@linux.intel.com> <20240527144356.246220-2-fabio.m.de.francesco@linux.intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240527144356.246220-2-fabio.m.de.francesco@linux.intel.com> X-ClientProxiedBy: MW2PR16CA0054.namprd16.prod.outlook.com (2603:10b6:907:1::31) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|SA1PR11MB6616:EE_ X-MS-Office365-Filtering-Correlation-Id: edc02064-6e78-4fc7-df92-08dcb64d0aa7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Q3KKaD+JTuJ6a2tRvzX8tY7lzIfqn0jCbwuirK6XKe410B2S1p++OmPhO+V9?= =?us-ascii?Q?JdKPxGzQZe+f5D2rsLsxeedlKj51s3nudiOuxselvaYqbYPj/fTNjCM9nQvd?= =?us-ascii?Q?rDC4ANmD1gWAbsFvE0pzk9/oO7IGcJkJfkkUYCkX5V9b3T4UV/XHXSpU93nn?= =?us-ascii?Q?ZJojD/MkWB8K0PJwhvf3WvnKgY1ZE0z46exIhQv2Pz/c1e535/U8UWnutEpb?= =?us-ascii?Q?3cOUWJgsiFJ849W/1J8rAqQvAdffc6WO+B2KNaVxKzq2ViHyqpUyRmPEUQoc?= =?us-ascii?Q?ajiXAbpgt3T/2Hwy1Lm9v5A4ot1WPMgzAr/XYUcxZe2qtAi8yRWGPwo5GhuP?= =?us-ascii?Q?K3OtDep2o9OFooF3KoKIErEF36agbXjg2zDv+3CROQo4R3eMJSks+0JSecFG?= =?us-ascii?Q?eHnKdEmYnLGxr4oO2nB+IPeR7xg0HHuyEAdCOQjGWIuHdVhJGTWQ1isY74X4?= =?us-ascii?Q?RMoRYq922TaL3rcyczCazgciajadZ+NL1pM8DgFQX9vmWTjfOHv6S2TThslu?= =?us-ascii?Q?JdiR4mQvYnKRkViwqZrcvJOaUbz/0khnrYF1GF47gw2LBeGm45J2SHwQvTky?= =?us-ascii?Q?cbcFBSLvST6N42fymFu5s4ZufL8nwe9LZ7iayq0eHTiWGQzBKeExnrdnGQoG?= =?us-ascii?Q?ne6ftNiYnSijfS5uRZCy4/WeULZvBndX73wASx8s0voKrFcsf37Jajhy9YcF?= =?us-ascii?Q?6OJtdxTLczjnRLNnw/AVEHijk54dFoEnGpazdLxyuh3++aEDD1R//DMivddk?= =?us-ascii?Q?24cAebiFGrDWtlhSfMcJcrd7lCHN41aPEiEpBMr7whQW0MS8SlGhkWAi5S8+?= =?us-ascii?Q?ZS1QgRfhpU94melRbr3Ne7I8sGVbFtN5OR7Hi9s2Bz/mqJa9dgPIWFsiFMSf?= =?us-ascii?Q?wB65td5mJgIGm7wGH1GLNrxcKI1tXETA/Jyfq3Ub6O4d2LxQiojECvc+clX5?= =?us-ascii?Q?jLNiItdKCZhpHwpURD1RgfiQSOElu25svFGixoCCR9WNJFEZFtKvuhw3MHst?= =?us-ascii?Q?4XjDbu2drFx8xLP9qmhPWYwm7EMDArUD4aRB7t1JdnRwJ7oeM4w19vV1BgUk?= =?us-ascii?Q?JCtYhG+S8YJ2e5VeABwO03tFHvnn7SKvrytG9eAwPfsoa6drY1NuOQ3UCYUH?= =?us-ascii?Q?W7eWRFWXAiX8Jx5aJJgbko+8cadBSJA+oxodYyQMb9ghb2+bljgN3XhBUTeE?= =?us-ascii?Q?Vgk9q4rTbT2SM9fn7AhSZuyTHfifiSYm8yFUbedHJ/eOYzVJdKveDIGX9YzV?= =?us-ascii?Q?Z60Aav3aq23qhGqSzPcXb53RcrvdxU5W4MMwm/QpaItxdI/6YKxAmPpVKTw4?= =?us-ascii?Q?MjIbeHd+ZLKJQrOGXD5DyTqeSg1kgRIDKcB5lT9xE0toRzO1xrZU538Rl4I2?= =?us-ascii?Q?y3CJWNjt1JwzVo/XeqUaLPmIj2i5?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rESFE4ljys8qOy1XFixg0VH1rvwkDRtSvVaccoSbG9fvGbTBI9mT6Yfqg8/H?= =?us-ascii?Q?ZSMva5XQLJhctzpUDkrNRyJy89NxeYqWDo271UxN/UK0KlY5kAg+wOWCaZ8o?= =?us-ascii?Q?abjxyqR8Og0l7A0/lBDurZdkvFmguSI/YbSmgJElhM2gaObxLOG9Wf654N5W?= =?us-ascii?Q?DG5LedQhb9anOXLRVwWJHCDz4/H2wyCn0C6AA46Te3OGAJU4xFBPVwphBT20?= =?us-ascii?Q?dvhQC3/LhCXk7bHrCx318ICPXo/mRiX9sCBvC6KCudthLqF9Y8ICB7aZygNc?= =?us-ascii?Q?AD24cIU6NKEvLaPHt4X02UwtDJBdMmYngJdVCf2JKbpBCyvyKbcfwTcPTxQd?= =?us-ascii?Q?Tw+L5v2iflqwZeGkQOuNUGUoCFqSkCz4My5nJszwRmEff35yGyZlCmviWnDR?= =?us-ascii?Q?3wq0W9aOUCTGfd1Up1Q6J0gF1LzqfVwdqO8CRIpNmQwC/vI5vM1qFA4vez9c?= =?us-ascii?Q?acMeLDGTxDIW7i7GPYHjahYP9/Qz86WfaT2fnBSdqX7m9ebkXMy5cTgW8QcP?= =?us-ascii?Q?4d/muqkh2jxljqMzvW6+mXXW5r/J2KoH9kqUahfp0YmDMdOqun/YLQPPsFGl?= =?us-ascii?Q?Eg6MPLu7Y9yNKoV3YVhgvDpVIuiQ4XibDgHWYYaxVJmYaXgW66FZ3KWsgDIE?= =?us-ascii?Q?sijD3WdFP80H9B+IytfiNtRP+b3XxZ+OPuuSUnH1K6/1Z5xuSgMha/Ow65tm?= =?us-ascii?Q?h1yb7t4tD9tXd4CzxaibwmE/iNijYbPbhgmqU16QKLm/3ouMEqNM47cbEv4V?= =?us-ascii?Q?/1On/eevAqZAbRTTObAmo7iVC3ghUdMKPQqGAxqpK2aNiMVXir3QaNW/G29h?= =?us-ascii?Q?LiebJhGY31/DIGlXB189ipVYxzkmbiB5VKqoQ37+mHC798qiBohXDiXKfdWy?= =?us-ascii?Q?u2EAEGz5QXhUEumfaxHcMyCgQKgq7wXH2yjZIStNtT0xe2acpVAVpFP3j/0S?= =?us-ascii?Q?J0M4XmI/8LnIFrGVaTDmMgtLBfxDsJew1jJUU0CzykLnVwm9v8Ml8A29khtg?= =?us-ascii?Q?wUNvfw8oM7PEaNi1C18z7W4HeQ4T9yg8TDZ7miQLeo/St7JMqkZmvi9z5yAn?= =?us-ascii?Q?+v49o7fHfxRwmjbSxNhn36lwmaKgh36m0ocBup70725Bvr8XDuDD3WsAZo7i?= =?us-ascii?Q?/YnF5m26JISwgThzd3JoZfdtwRAshJ0IhCyXOMxYCWXOhCtfGiLIHCzX93Y4?= =?us-ascii?Q?zXQfTc/UqpaA3u5sLoYjo2FNgKCN421Tkgfz+DKVZN35nWfH45yr2NB7rN1x?= =?us-ascii?Q?dV0Mxle0FMIWngr55IvUyYtAFw5KB+w7rNrSPds4OR9OUSjol7z8HdwbjbuP?= =?us-ascii?Q?J8HeJmkEjJUwx1Zk+YxksSJotAau1InrV+pLOJNK+yyYuaDDXokyJsqtItO9?= =?us-ascii?Q?K4O5e0EFRWjJhF2wPEX12WaZIggtizk8mIABX6U/AakJaWWGmIt4kYZKG/1J?= =?us-ascii?Q?AjQkClVUEKCrLq22zYEPGvdg9rsP9u97Ki3cqCgx3VREdt45o/Cs+NXLEWXD?= =?us-ascii?Q?/fiH3EzNVlYgZmNUMGbpkHlk4ANPG8Xn9J2XCdsGnuNOqn1Fzb82e01nNPgL?= =?us-ascii?Q?s27bDYMNg59ix2OgYFquqob7Mk1kp2qz1UxRF/QmgTvjBN5dfEL0rTuc9ZDS?= =?us-ascii?Q?tQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: edc02064-6e78-4fc7-df92-08dcb64d0aa7 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2024 19:21:58.8900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GFONW5VZk9SlJ9sO3ubsaAIUtnR93HSNpaVrZ0Rab8P0B8RgcUww2GdDMtu8GNy1qo5HwnSobNuT5azxEnOJ3z2/uUXP7mOwfKB+/IiiHQU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6616 X-OriginatorOrg: intel.com Fabio M. De Francesco wrote: > In extlog_print(), trace "Non-standard Section Body" reported by firmware > to the OS via Common Platform Error Record (CPER) (UEFI v2.10 Appendix N > 2.3) to add further debug information and so to make ELOG log > consistently with ghes_do_proc() (GHES). I think this description could be clearer, how about: --- ghes_do_proc() has a catch-all for unknown or unhandled CPER formats (UEFI v2.10 Appendix N 2.3), extlog_print() does not. This gap was noticed by a RAS test that injected CXL protocol errors which were notified to extlog_print() via the IOMCA (I/O Machine Check Architecture) mechanism. Bring parity to the extlog_print() path by including a similar trace_non_standard_event(). --- > > Cc: Dan Williams > Signed-off-by: Fabio M. De Francesco > --- > drivers/acpi/acpi_extlog.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c > index f055609d4b64..e025ae390737 100644 > --- a/drivers/acpi/acpi_extlog.c > +++ b/drivers/acpi/acpi_extlog.c > @@ -179,6 +179,12 @@ static int extlog_print(struct notifier_block *nb, unsigned long val, > if (gdata->error_data_length >= sizeof(*mem)) > trace_extlog_mem_event(mem, err_seq, fru_id, fru_text, > (u8)gdata->error_severity); > + } else { > + void *err = acpi_hest_get_payload(gdata); > + > + trace_non_standard_event(sec_type, fru_id, fru_text, > + gdata->error_severity, err, > + gdata->error_data_length); > } ...with the above changelog update the code change looks good to me, you can add: Reviewed-by: Dan Williams