From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA3E7160884; Mon, 13 Jan 2025 23:45:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.20 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736811937; cv=fail; b=HOB6ZvGK45zX6t3Jh+oCqwxZMI1EovMiBcGoA6IK25VQhn0tUyscLbhcG2Ic9EggyV+cSEJv0g2A91pQlPWAzEx7U51jrs/evG6I6Y1SON0z8WtjaqtYRB96cO+NW/+wPXlBmZU2A1hh84dm3SPCB+uyCHYLvsHF4R+lZPkl+QQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736811937; c=relaxed/simple; bh=d8niIFBWM0p0RvM5jvzWm5K7vjL/G2B9wE5egH6LoHE=; h=Date:From:To:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=qO6vNiFUdiE6pnSjFeqRZg9M6S91DizLJiPx394h/PMThq+hW3BzNE9ne53AuzwyJj8knk03jKDyCX7bLnbMWOCMQgCzlpfgngitDBR0mLcnINqO69e66CaVDlhDM6XxfFBDGLRQ32IvfhHIhM3iV7W8h+bv00qdyspsQj/cbdk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lvgH1hBh; arc=fail smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lvgH1hBh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736811935; x=1768347935; h=date:from:to:subject:message-id:references:in-reply-to: mime-version; bh=d8niIFBWM0p0RvM5jvzWm5K7vjL/G2B9wE5egH6LoHE=; b=lvgH1hBhUTGgq0QP8rzHxp3C0rwibTBWK2HrUtrkJ4kWYbti6NeC07jT Hamqh5hVaETeioMvRBzO6f7a+Av5qlNtCSS9IXpMUx0ifCuhWbLRZZ0q2 NgFWpm70x0j3LIkf4+HsIGDUNDvqt3WQ3vbGA1828Zzvho9GVezIWren4 TvnjcaQSz0RT1OQJAgZ2n6zWx33046lD54jOvVM8P3T27EOWwjxgZLSq8 Tnhdj4JUrxG975JuTHfQwExfYUBuELBOkFyEsXE5Y+WE+gXQjJyBCt5H8 4ZpxrEhcaZTZbZ4H+O+AydZPK5N+TFxAMvgQ5/jTKrC2ZugufdZExrgjf Q==; X-CSE-ConnectionGUID: kzYvn8KYRK63nV+f+jcZcg== X-CSE-MsgGUID: FR5uTYVTQxePtKxW40AxtA== X-IronPort-AV: E=McAfee;i="6700,10204,11314"; a="36784885" X-IronPort-AV: E=Sophos;i="6.12,312,1728975600"; d="scan'208";a="36784885" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2025 15:45:32 -0800 X-CSE-ConnectionGUID: 0c/9VcY/QLuJlTZt1In9wQ== X-CSE-MsgGUID: 8+YhlM0+TXKJnFd3AEF6WQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="105133895" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Jan 2025 15:45:19 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 13 Jan 2025 15:45:18 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Mon, 13 Jan 2025 15:45:18 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 13 Jan 2025 15:45:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b0w5R+Ip4RX5BsmHTPo9k6f2R6iyFsRorAgXzlrXioO0JJJkgr7rKVjonqnJxJYcT2LSZ7NC3lX54SWWY2yCXbsxc84NwkOULbhBoaxp5anXAKmJPdpGowzZh/Xh2KTMb5vSfUHZSxJMpewThRGWbF7BnsuGguLzZyCoh1FNwn4/VXthp5q8W5lCgbBWN7rXzhHFAnwKxYIO5rKIbZlMAZ93SG3/cvPRGi3rdoWTq1E+vDC13+fBQlsfQPAlrGV++6UkFncxtulMkY+3gqKDPzk+eeS7P8S7gFp18kx69RfwXNWIJuKHN+zlcEVrSnL/rFODc/jy1RtFoGB7lfeCWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MLQN3AdFYtZwee7NOKs3I18Q4I076IKYmF36d4IYMmQ=; b=MT3LweO49r27JVw7SJYc0uD/FHEl2lOmRTQRUwFF+tL8pBrmH5eVmk7yaYOqsuftLgVXXFsTvjx15D60X1sKUH6Iz7CHbcal2ER/+RfVacGEM/YuJF/gu5K/cBM6lX6+FUqVrp7dkKaO8R9zDeAhRdJE7YcjcVb8YU5fTSOQVrAjXUosAF7DOZwA6NO0g32aODEnKh/uakhqsqfgebFiaJX/98xKLeXp2QVni293vlE2i8FaHPxSZIluMVY3kda+3ZGIOS7uEoCcYXqOebSFnApi1jq//iYg7j+x+w42dQedlidQS+mxRZ8+s5B62yLP2SHqV9l0xfndnaCRvDbjXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SA1PR11MB6733.namprd11.prod.outlook.com (2603:10b6:806:25c::17) by SA2PR11MB5099.namprd11.prod.outlook.com (2603:10b6:806:f9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Mon, 13 Jan 2025 23:45:17 +0000 Received: from SA1PR11MB6733.namprd11.prod.outlook.com ([fe80::cf7d:9363:38f4:8c57]) by SA1PR11MB6733.namprd11.prod.outlook.com ([fe80::cf7d:9363:38f4:8c57%5]) with mapi id 15.20.8335.012; Mon, 13 Jan 2025 23:45:16 +0000 Date: Mon, 13 Jan 2025 17:45:09 -0600 From: Ira Weiny To: Terry Bowman , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 01/16] PCI/AER: Introduce 'struct cxl_err_handlers' and add to 'struct pci_driver' Message-ID: <6785a58538832_186d9b2945f@iweiny-mobl.notmuch> References: <20250107143852.3692571-1-terry.bowman@amd.com> <20250107143852.3692571-2-terry.bowman@amd.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250107143852.3692571-2-terry.bowman@amd.com> X-ClientProxiedBy: MW4PR03CA0268.namprd03.prod.outlook.com (2603:10b6:303:b4::33) To SA1PR11MB6733.namprd11.prod.outlook.com (2603:10b6:806:25c::17) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB6733:EE_|SA2PR11MB5099:EE_ X-MS-Office365-Filtering-Correlation-Id: 366f8253-b94a-4ab4-7ab2-08dd342c54fb X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016|921020|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DCGqJAhEUDgiUX06erIOeserZoYuVwveWxAFvqRknvhCGrtnuNpU0TQHh6Bc?= =?us-ascii?Q?ijI/aJhMgpzt3FyeANJhcP68Ou1/+SH3piXXzm2jbrNIpA+ZuftnkNeV/L6z?= =?us-ascii?Q?AeQ9Ut8xHnnmM2kummkmCoQJi+vN+8p+zWkwHwHrNZVxZGmWZph4+WFd0MVp?= =?us-ascii?Q?wjs98wE3RHS10XpcRgaVVOWnzJJJq0Z1/43sjfxXG9WUVfvMpy1ukmcszXBh?= =?us-ascii?Q?rNmrXLbT8AFzS8kAyTh3WjL3lQ27kJth0eGniFYjgqzVQyMqwBzcN08Bp1ij?= =?us-ascii?Q?r8eKhyUUpUhdgX3Uw3EpFm2stA70d+F5e4Ls1j3aZaiL70RCYONge4Y0Gb1C?= =?us-ascii?Q?o1TQYgOgSOHFM3hxAANTEuvgCzQLs2X7VxsV2LHm77+rGRUb/56lRGpORGru?= =?us-ascii?Q?UhcsfVkGUgRzbWxD7k/4/5Vt5zaywqu6Gdblfxsqmi3FX3RINpRdGqfiNlsS?= =?us-ascii?Q?Yf8twWa5wFw1o2bPU2ASfEvUpznPY0/GX/ufSw8QmzcqUo+lhPhJ1uUXdyMc?= =?us-ascii?Q?2sF4D2EziynMEniSKzXfhuKU13QZLQsMesh83jTzdFhrLBPmQgAsh0Pka0gd?= =?us-ascii?Q?UizDoyTxGKumAkkejow+tj6MWR5ueGSRBsirwTq/V7fW2NTeMrFDmhC9+9hP?= =?us-ascii?Q?17LOsZACmc8frAyZ/8V4WMxGpIUtear/czxTN1fBk0Umomt6wFXHdOgVFEdC?= =?us-ascii?Q?kLESVM+zulChEqr6nZMw3nsBj/Fm/TiseUp3uxL/ZTQ9YkWJTNlsk4WVfXKA?= =?us-ascii?Q?oIXwpXF2Fi+i+p4+zP+MpRWjQpRLTG2YHItCTQcZkr/7Zx1mpuX7rN1vGJv3?= =?us-ascii?Q?9LampAWzA4Qnk8GCQggjQEWtXuX7LBqmbutMuJAu2pnLkNcm5nyfBtPgz543?= =?us-ascii?Q?lbYZ0Luq1PAsQBnEY+HahuqybHTO/URDVIdDYe+Bi2WvygM09uhtI0Xo911r?= =?us-ascii?Q?nUBbwYzemgJE7Oq1yELcglXmlG90F+RV0eCrPLHLyuEtHWRmF2jZWds9reQe?= =?us-ascii?Q?gok8omSiVLYY3Y9QprK8KQWNQqgDKEJcN4bcOdxu1qaG48KFwUaIXm9wJ/Pj?= =?us-ascii?Q?7lcWNncFktYpuvzvVywe0Yvi0fWUCl4mEyq9xQivmkn++QoVGrgGqluwmwZQ?= =?us-ascii?Q?wiDbA/xl3l4khUwslKFzZQBmHxvHanIUBU1LiT4lMV7UTOv91jp3eueWigys?= =?us-ascii?Q?NVulyURFQP5UcB9SysVIYGKGWFtOaswmFeRr2WdjhZEM3dmBu7/LGQb5K8Dy?= =?us-ascii?Q?BufH8DQGXfqCyeWTTb3RnlVvb+knIKKchf/1A6NNEQpsqlNveEolenjKDA+T?= =?us-ascii?Q?P2MsGEzQ8U1goTjlb7w921hTo0jc9cuWZO7Io1jgClw7hDXNd6qcQlXJxT6a?= =?us-ascii?Q?3/pn247/cnM8rlsSCYCT6/e94vk6SC47Pfxkot7iSZCRJfDRgUDCZf4Ru6Go?= =?us-ascii?Q?Ur0eDi8rtbQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB6733.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016)(921020)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OMs4clOatB3NuWO64+8W29R6jkxQFoBUSnaHY99fcAIfTshksWPUyo9FJnha?= =?us-ascii?Q?//qnbWkgBaGnsfAhvdrf8f4UWn8jYqE8t0Phi4saAH4po03uwiV7dp0BwUYK?= =?us-ascii?Q?944KsBnDAfVbfvEqofNqk0Iw5H/b+QtDKcDdiCWzx3wpwgJy4gP1UupSPlzv?= =?us-ascii?Q?0t6DBEIjkXrfm2yTobnI2fmNIZnBv80is3/5kDRXNtOzKJySRuVT0NwtiU+/?= =?us-ascii?Q?DD8GRO1psNCiVdXXWoigWSgQojD7xarfZ/p/NPtZ42GLqdrBITjP/MgVYMnH?= =?us-ascii?Q?NGIlg46ZOY0henlHHQhJmhlYHUh0MRBsa9Dh51c3QtUlJuD7l0AGBxS/F0/W?= =?us-ascii?Q?in+EFImWnOfJdyACOngmIKPDPV4SH8jwq+AQiHlWlQEsh1EkbM/5b64S2oqY?= =?us-ascii?Q?4jOKw308kP36Jn0O77wcQIKQIhIRxJd6Bb7KsIxiw70czCRppAZsOnAQOduJ?= =?us-ascii?Q?chbrsSxQqVCCCijPfqj218T+/klZn+6v7fMjP7J1IKzrrKpFTlobQyc3UKcC?= =?us-ascii?Q?J73NizxjMOQBvmZLPk8PJsNIx8xCJkcmKr2G/ahsyztw9qgdR+b5Wck/t2Gm?= =?us-ascii?Q?aNxb2JnwdrjC2sMRvP+NewZ0Y4HjoUHPRDLOHB6nf6GrEWDe/Idha1l7/B7Q?= =?us-ascii?Q?yLzJDKrIheGywBeLBAmttm24Q1Fz/FZE2VSJCXj9tVrWCfmW/Fg1uO9Q8n+Z?= =?us-ascii?Q?Ht2/GAd/q0wWMlzy+6wh4LrYTyQQOPobqoeMH5iYrxTBMSqoO1lq51ADCVUA?= =?us-ascii?Q?uuJRnMJ/2k5kKHm5nc4W2casKgWFBXd3TbraDD8X3Cow5Xa1F4EQk4SVt3dB?= =?us-ascii?Q?5gqPJX97HazXK7AeUm3svsgJHlM+8yN/bg253rIr5YMG4hBP1TR/vODKeo+i?= =?us-ascii?Q?qKGgIPyaLY+AIPX5CMt8AyJZrNy4tXAlbreTGjg1+RbyyTPA6vAE6q/NGMi+?= =?us-ascii?Q?Cbzoc4h4AATnMd/LSlXZhFch43gOsR/S4tYCVzunoTqPuBP6cFEFm3OmGyKR?= =?us-ascii?Q?vHr7yWfzB4npYfLAwlROybMC4NR6jSvC9/hOxz2WISHw3YGKnHg9PMhn9fjo?= =?us-ascii?Q?Ty5LhAeWTZcf5t91TdSmKi13d9210jNVBGbdB/LP4QXEsY1qtbBjtmoxc9t3?= =?us-ascii?Q?sPorcv1bpr+qptXlabZgaetQQZ+bVr0ylx4oVXzpOz66vmjMNNc1Sxlni/Mk?= =?us-ascii?Q?ZZD4Ai6wVazoxUDgwcFEgGUeYW2z08sN03GD9wbhMfU2b+yhX8qLkEUPFbGQ?= =?us-ascii?Q?Y0KgSfSiLFXRz7zxw3sIpz+vcBNKiePaXwiGctTIMP6NtzBUgqyF3hUs62Na?= =?us-ascii?Q?eHwc7ii2dRyl1h6drCShLl3EM5oLekTAVqgFfRyPaO5Zi3HnodUJ8Zyds82G?= =?us-ascii?Q?30q+Spvcm6n8iesvEMNYZoxkDB+UIfveturS8TueTZoMPJuXhhwNqruY+x0l?= =?us-ascii?Q?6WBZ8prwftf3UfiPaymPd+W8V/4F8bJIcBiIbRnfZPxKrWUvADsgf7g7Jpgq?= =?us-ascii?Q?fht1n/8Mwg4shgicQtggv/V0XGlrIFL/S5CzgQSjiIJbz92F3cBpJhs4hhER?= =?us-ascii?Q?NHEwTfX8t8SfNNocbyX7uwoJC6YkVGGYNlu6gvoB?= X-MS-Exchange-CrossTenant-Network-Message-Id: 366f8253-b94a-4ab4-7ab2-08dd342c54fb X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2025 23:45:16.7926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ks1dSK9kM+BgxDqioIjhnz1qv9nMcwcqTI3pycsBjOfh6c+BDvm7sqccAXBSpwKR/34UKxLlhb9laSKLJdhR3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5099 X-OriginatorOrg: intel.com Terry Bowman wrote: > CXL.io provides protocol error handling on top of PCIe Protocol Error > handling. But, CXL.io and PCIe have different handling requirements > for uncorrectable errors (UCE). > > The PCIe AER service driver may attempt recovering PCIe devices with > UCE while recovery is not used for CXL.io. Recovery is not used in the > CXL.io case because of potential corruption on what can be system memory. > > Create pci_driver::cxl_err_handlers structure similar to > pci_driver::error_handler. Create handlers for correctable and > uncorrectable CXL.io error handling. > > The CXL error handlers will be used in future patches adding CXL PCIe > Port Protocol Error handling. > > Signed-off-by: Terry Bowman > Reviewed-by: Jonathan Cameron > Reviewed-by: Dave Jiang > Reviewed-by: Fan Ni Reviewed-by: Ira Weiny [snip]