From: <dan.j.williams@intel.com>
To: Keith Busch <kbusch@kernel.org>, <dan.j.williams@intel.com>
Cc: Keith Busch <kbusch@meta.com>, <linux-pci@vger.kernel.org>,
<helgaas@kernel.org>, <alex@shazbot.org>, <lukas@wunner.de>,
<guojinhui.liam@bytedance.com>, <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCHv3 3/4] pci: remove slot specific lock/unlock and save/restore
Date: Tue, 10 Feb 2026 15:48:40 -0800 [thread overview]
Message-ID: <698bc3d88de4_8c3210058@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <aYu-fk1AIXtG-YnF@kbusch-mbp>
Keith Busch wrote:
> On Tue, Feb 10, 2026 at 02:03:54PM -0800, dan.j.williams@intel.com wrote:
> > Keith Busch wrote:
> > > From: Keith Busch <kbusch@kernel.org>
> > >
> > > The Linux pci driver resolves a "slot" to the "D" in the B:D.f (see
> > > PCI_SLOT()). A pcie "slot reset" is a secondary bus reset, which affects
> >
> > Maybe change "pci" and "pcie" to "pciehp" above to make it clear this problem is
> > specific to the native PCIe hotplug driver?
>
> Good point, and given that, should I just drop this patch? The previous
> one fixes up this slot assignment issue for pciehp, so we could consider
> taking either "2" or "3", but not necessarily both. I included both in
> this series because I'm not sure if there is a preference. My best
> reasoning to take both is if we want to proactively handle the entire
> bus for all platforms requesting a slot reset, but also leave us an easy
> revert if it causes a problem.
My only comment there would be that the bug fix that happened in "2" was
subtle. So I would say at a minimum clarify "2" as a fix for pciehp and
that "3" is a opportunistic fix for other reset scenarios. ...if I
understand the incremental value of "3" correctly.
next prev parent reply other threads:[~2026-02-10 23:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 21:25 [PATCHv3 0/4] pci slot reset handling fixes Keith Busch
2026-02-05 21:25 ` [PATCHv3 1/4] pci: rename __pci_bus_reset and __pci_slot_reset Keith Busch
2026-02-06 17:22 ` Keith Busch
2026-02-10 20:44 ` dan.j.williams
2026-02-05 21:25 ` [PATCHv3 2/4] pci: allow all bus devices to use the same slot Keith Busch
2026-02-10 20:00 ` dan.j.williams
2026-02-10 20:28 ` Keith Busch
2026-02-10 20:51 ` dan.j.williams
2026-02-05 21:25 ` [PATCHv3 3/4] pci: remove slot specific lock/unlock and save/restore Keith Busch
2026-02-10 22:03 ` dan.j.williams
2026-02-10 23:25 ` Keith Busch
2026-02-10 23:48 ` dan.j.williams [this message]
2026-02-10 23:46 ` Alex Williamson
2026-02-11 0:12 ` Keith Busch
2026-02-11 15:22 ` Alex Williamson
2026-02-11 15:54 ` Keith Busch
2026-02-05 21:25 ` [PATCHv3 4/4] pci: make reset_subordinate hotplug safe Keith Busch
2026-02-10 22:14 ` dan.j.williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=698bc3d88de4_8c3210058@dwillia2-mobl4.notmuch \
--to=dan.j.williams@intel.com \
--cc=alex@shazbot.org \
--cc=guojinhui.liam@bytedance.com \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox