From: Dan Williams <dan.j.williams@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Keith Busch <kbusch@meta.com>
Cc: <linux-pci@vger.kernel.org>, <dan.j.williams@intel.com>,
<alex@shazbot.org>, <ilpo.jarvinen@linux.intel.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv5 2/3] PCI: allow all bus devices to use the same slot
Date: Wed, 11 Mar 2026 12:35:29 -0700 [thread overview]
Message-ID: <69b1c401a109b_21321009f@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <20260309205009.GA582379@bhelgaas>
Bjorn Helgaas wrote:
> On Tue, Feb 17, 2026 at 08:08:35AM -0800, Keith Busch wrote:
> > From: Keith Busch <kbusch@kernel.org>
> >
> > A pcie hotplug slot applies to the entire subordinate bus. Thus, pciehp
> > only allocates a single hotplug_slot for the bridge to that bus. The pci
> > slot, though, would only match to functions on device 0, meaning all
> > device beyond that are not matched to any slot even though they share
> > it. A slot reset will break all the missing devices because the handling
> > skips them.
>
> I tweaked this a bit to (a) refer to the "secondary" bus instead of
> "subordinate" to avoid confusion with the PCI "subordinate" term
> ("pci_dev->subordinate" already has this confusion but is harder to
> fix), and (b) mention ARI, which I think is what causes the problem
> you're solving:
[..]
> Let me know if I got any of this wrong.
Looks good to me and matches my understanding of what Keith is fixing.
next prev parent reply other threads:[~2026-03-11 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 16:08 [PATCHv5 0/3] pci slot reset handling fixes Keith Busch
2026-02-17 16:08 ` [PATCHv5 1/3] PCI: rename __pci_bus_reset and __pci_slot_reset Keith Busch
2026-02-17 16:08 ` [PATCHv5 2/3] PCI: allow all bus devices to use the same slot Keith Busch
2026-03-09 20:50 ` Bjorn Helgaas
2026-03-11 19:35 ` Dan Williams [this message]
2026-02-17 16:08 ` [PATCHv5 3/3] PCI: make reset_subordinate hotplug safe Keith Busch
2026-02-26 22:41 ` [PATCHv5 0/3] pci slot reset handling fixes Keith Busch
2026-03-05 23:17 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69b1c401a109b_21321009f@dwillia2-mobl4.notmuch \
--to=dan.j.williams@intel.com \
--cc=alex@shazbot.org \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox