Re: [RFC PATCH 2/3] Add PCIe enclosure management auxiliary driver

[stuart hayes <stuart.w.hayes@gmail.com>]

On 1/31/2022 5:59 AM, Mariusz Tkaczyk wrote:
> Hi Stuart,
> On Mon, 17 Jan 2022 22:17:57 -0600
> Stuart Hayes <stuart.w.hayes@gmail.com> wrote:
> 
>> +	switch (output->status) {
>> +	case 0:
>> +		break;
>> +	case 1:
>> +		pci_dbg(pdev, "_DSM not supported\n");
>> +		break;
>> +	case 2:
>> +		pci_dbg(pdev, "_DSM invalid input parameters\n");
>> +		break;
>> +	case 3:
>> +		pci_dbg(pdev, "_DSM communication error\n");
>> +		break;
>> +	case 4:
>> +		pci_dbg(pdev, "_DSM function-specific error 0x%x\n",
>> +			output->function_specific_err);
>> +		break;
>> +	case 5:
>> +		pci_dbg(pdev, "_DSM vendor-specific error 0x%x\n",
>> +			output->vendor_specific_err);
>> +		break;
>> +	default:
>> +		pci_dbg(pdev, "_DSM returned unknown status 0x%x\n",
>> +			output->status);
>> +	}
>> +}
> 
> I tired to compile it and I failed:
> drivers/misc/enclosure.c: In function ‘led_show’:
> drivers/misc/enclosure.c:607:3: error: label at end of compound
> statement default:
>     ^~~~~~~
> drivers/misc/enclosure.c: In function ‘led_set’:
> drivers/misc/enclosure.c:644:3: error: label at end of compound
> statement default:
>     ^~~~~~~
> make[2]: *** [scripts/Makefile.build:288: drivers/misc/enclosure.o]
> Error 1 make[1]: *** [scripts/Makefile.build:550: drivers/misc] Error 2
> make[1]: *** Waiting for unfinished jobs....
> 
> My gcc version:
> gcc (SUSE Linux) 7.5.0
> 
> Could you please, resolve the issue?
> 
> Thanks,
> Mariusz
> 

No problem.  I'll send a v2 now.
Thanks,
Stuart