[PATCH 0/6] MT8188 DT and binding fixes

linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/6] MT8188 DT and binding fixes
@ 2024-09-25 10:57 Fei Shao
  2024-09-25 10:57 ` [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only Fei Shao
  0 siblings, 1 reply; 6+ messages in thread
From: Fei Shao @ 2024-09-25 10:57 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: Fei Shao, Alexandre Mergnat, Bjorn Helgaas, Conor Dooley,
	Fabien Parent, Jianjun Wang, Krzysztof Kozlowski,
	Krzysztof Wilczyński, Lorenzo Bianconi, Lorenzo Pieralisi,
	MandyJH Liu, Manivannan Sadhasivam, Matthias Brugger, Rob Herring,
	Ryder Lee, Ulf Hansson, devicetree, linux-arm-kernel,
	linux-kernel, linux-mediatek, linux-pci

Hi all,

This series is split from a previous series[1] to focus on few fixes and
improvements around MediaTek MT8188 device tree and bindings, and also
addressed comments and carried tags from the mentioned series.

[1]:
https://lore.kernel.org/all/20240909111535.528624-1-fshao@chromium.org/

Regards,
Fei


Fei Shao (6):
  dt-bindings: power: mediatek: Add another nested power-domain layer
  dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only
  arm64: dts: mediatek: mt8188: Define CPU big core cluster
  arm64: dts: mediatek: mt8188: Add missing dma-ranges to soc node
  arm64: dts: mediatek: mt8188: Move vdec1 power domain under vdec0
  arm64: dts: mediatek: mt8188: Update vppsys node names to syscon

 .../bindings/pci/mediatek-pcie-gen3.yaml      |  5 ++-
 .../power/mediatek,power-controller.yaml      |  4 ++
 arch/arm64/boot/dts/mediatek/mt8188.dtsi      | 37 +++++++++++--------
 3 files changed, 28 insertions(+), 18 deletions(-)

-- 
2.46.0.792.g87dc391469-goog


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only
  2024-09-25 10:57 [PATCH 0/6] MT8188 DT and binding fixes Fei Shao
@ 2024-09-25 10:57 ` Fei Shao
  2024-09-25 13:59   ` Krzysztof Kozlowski
                     ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Fei Shao @ 2024-09-25 10:57 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: Fei Shao, Bjorn Helgaas, Conor Dooley, Jianjun Wang,
	Krzysztof Kozlowski, Krzysztof Wilczyński, Lorenzo Bianconi,
	Lorenzo Pieralisi, Manivannan Sadhasivam, Matthias Brugger,
	Rob Herring, Ryder Lee, devicetree, linux-arm-kernel,
	linux-kernel, linux-mediatek, linux-pci

In MediaTek PCIe gen3 bindings, "clocks" accepts a range of 1-6 clocks
across all SoCs. But in practice, each SoC requires a particular number
of clocks as defined in "clock-names", and the length of "clocks" and
"clock-names" can be inconsistent with current bindings.

For example:
- MT8188, MT8192 and MT8195 all require 6 clocks, while the bindings
  accept 4-6 clocks.
- MT7986 requires 4 clocks, while the bindings accept 4-6 clocks.

Update minItems and maxItems properties for individual SoCs as needed to
only accept the correct number of clocks.

Fixes: c6abd0eadec6 ("dt-bindings: PCI: mediatek-gen3: Add support for Airoha EN7581")
Signed-off-by: Fei Shao <fshao@chromium.org>
---

 .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml          | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
index 898c1be2d6a4..f05aab2b1add 100644
--- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
@@ -149,7 +149,7 @@ allOf:
     then:
       properties:
         clocks:
-          minItems: 4
+          minItems: 6
 
         clock-names:
           items:
@@ -178,7 +178,7 @@ allOf:
     then:
       properties:
         clocks:
-          minItems: 4
+          minItems: 6
 
         clock-names:
           items:
@@ -207,6 +207,7 @@ allOf:
       properties:
         clocks:
           minItems: 4
+          maxItems: 4
 
         clock-names:
           items:
-- 
2.46.0.792.g87dc391469-goog


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only
  2024-09-25 10:57 ` [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only Fei Shao
@ 2024-09-25 13:59   ` Krzysztof Kozlowski
  2024-10-01 19:53   ` Bjorn Helgaas
  2024-10-02 20:31   ` Bjorn Helgaas
  2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-25 13:59 UTC (permalink / raw)
  To: Fei Shao, AngeloGioacchino Del Regno
  Cc: Bjorn Helgaas, Conor Dooley, Jianjun Wang, Krzysztof Kozlowski,
	Krzysztof Wilczyński, Lorenzo Bianconi, Lorenzo Pieralisi,
	Manivannan Sadhasivam, Matthias Brugger, Rob Herring, Ryder Lee,
	devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
	linux-pci

On 25/09/2024 12:57, Fei Shao wrote:
> In MediaTek PCIe gen3 bindings, "clocks" accepts a range of 1-6 clocks
> across all SoCs. But in practice, each SoC requires a particular number
> of clocks as defined in "clock-names", and the length of "clocks" and
> "clock-names" can be inconsistent with current bindings.
> 
> For example:
> - MT8188, MT8192 and MT8195 all require 6 clocks, while the bindings
>   accept 4-6 clocks.
> - MT7986 requires 4 clocks, while the bindings accept 4-6 clocks.
> 
> Update minItems and maxItems properties for individual SoCs as needed to
> only accept the correct number of clocks.
> 


Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only
  2024-09-25 10:57 ` [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only Fei Shao
  2024-09-25 13:59   ` Krzysztof Kozlowski
@ 2024-10-01 19:53   ` Bjorn Helgaas
  2024-10-02  3:35     ` Fei Shao
  2024-10-02 20:31   ` Bjorn Helgaas
  2 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2024-10-01 19:53 UTC (permalink / raw)
  To: Fei Shao
  Cc: AngeloGioacchino Del Regno, Bjorn Helgaas, Conor Dooley,
	Jianjun Wang, Krzysztof Kozlowski, Krzysztof Wilczyński,
	Lorenzo Bianconi, Lorenzo Pieralisi, Manivannan Sadhasivam,
	Matthias Brugger, Rob Herring, Ryder Lee, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek, linux-pci

On Wed, Sep 25, 2024 at 06:57:46PM +0800, Fei Shao wrote:
> In MediaTek PCIe gen3 bindings, "clocks" accepts a range of 1-6 clocks
> across all SoCs. But in practice, each SoC requires a particular number
> of clocks as defined in "clock-names", and the length of "clocks" and
> "clock-names" can be inconsistent with current bindings.
> 
> For example:
> - MT8188, MT8192 and MT8195 all require 6 clocks, while the bindings
>   accept 4-6 clocks.
> - MT7986 requires 4 clocks, while the bindings accept 4-6 clocks.
> 
> Update minItems and maxItems properties for individual SoCs as needed to
> only accept the correct number of clocks.
> 
> Fixes: c6abd0eadec6 ("dt-bindings: PCI: mediatek-gen3: Add support for Airoha EN7581")
> Signed-off-by: Fei Shao <fshao@chromium.org>

It looks like most changes to this file have been merged via the PCI
tree.  I don't see dependencies on this in the rest of the series, so
I'm happy to take this via PCI if it makes sense.  Or if you prefer
that this be merged with the rest of the series, that's fine and you
can add my:

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Let me know if I should pick this one up.

> ---
> 
>  .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml          | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 898c1be2d6a4..f05aab2b1add 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -149,7 +149,7 @@ allOf:
>      then:
>        properties:
>          clocks:
> -          minItems: 4
> +          minItems: 6
>  
>          clock-names:
>            items:
> @@ -178,7 +178,7 @@ allOf:
>      then:
>        properties:
>          clocks:
> -          minItems: 4
> +          minItems: 6
>  
>          clock-names:
>            items:
> @@ -207,6 +207,7 @@ allOf:
>        properties:
>          clocks:
>            minItems: 4
> +          maxItems: 4
>  
>          clock-names:
>            items:
> -- 
> 2.46.0.792.g87dc391469-goog
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only
  2024-10-01 19:53   ` Bjorn Helgaas
@ 2024-10-02  3:35     ` Fei Shao
  0 siblings, 0 replies; 6+ messages in thread
From: Fei Shao @ 2024-10-02  3:35 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: AngeloGioacchino Del Regno, Bjorn Helgaas, Conor Dooley,
	Jianjun Wang, Krzysztof Kozlowski, Krzysztof Wilczyński,
	Lorenzo Bianconi, Lorenzo Pieralisi, Manivannan Sadhasivam,
	Matthias Brugger, Rob Herring, Ryder Lee, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek, linux-pci

On Wed, Oct 2, 2024 at 3:53 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Wed, Sep 25, 2024 at 06:57:46PM +0800, Fei Shao wrote:
> > In MediaTek PCIe gen3 bindings, "clocks" accepts a range of 1-6 clocks
> > across all SoCs. But in practice, each SoC requires a particular number
> > of clocks as defined in "clock-names", and the length of "clocks" and
> > "clock-names" can be inconsistent with current bindings.
> >
> > For example:
> > - MT8188, MT8192 and MT8195 all require 6 clocks, while the bindings
> >   accept 4-6 clocks.
> > - MT7986 requires 4 clocks, while the bindings accept 4-6 clocks.
> >
> > Update minItems and maxItems properties for individual SoCs as needed to
> > only accept the correct number of clocks.
> >
> > Fixes: c6abd0eadec6 ("dt-bindings: PCI: mediatek-gen3: Add support for Airoha EN7581")
> > Signed-off-by: Fei Shao <fshao@chromium.org>
>
> It looks like most changes to this file have been merged via the PCI
> tree.  I don't see dependencies on this in the rest of the series, so
> I'm happy to take this via PCI if it makes sense.  Or if you prefer
> that this be merged with the rest of the series, that's fine and you
> can add my:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Let me know if I should pick this one up.
>

Yes please, thank you!

Regards,
Fei



> > ---
> >
> >  .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml          | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > index 898c1be2d6a4..f05aab2b1add 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -149,7 +149,7 @@ allOf:
> >      then:
> >        properties:
> >          clocks:
> > -          minItems: 4
> > +          minItems: 6
> >
> >          clock-names:
> >            items:
> > @@ -178,7 +178,7 @@ allOf:
> >      then:
> >        properties:
> >          clocks:
> > -          minItems: 4
> > +          minItems: 6
> >
> >          clock-names:
> >            items:
> > @@ -207,6 +207,7 @@ allOf:
> >        properties:
> >          clocks:
> >            minItems: 4
> > +          maxItems: 4
> >
> >          clock-names:
> >            items:
> > --
> > 2.46.0.792.g87dc391469-goog
> >

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only
  2024-09-25 10:57 ` [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only Fei Shao
  2024-09-25 13:59   ` Krzysztof Kozlowski
  2024-10-01 19:53   ` Bjorn Helgaas
@ 2024-10-02 20:31   ` Bjorn Helgaas
  2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2024-10-02 20:31 UTC (permalink / raw)
  To: Fei Shao
  Cc: AngeloGioacchino Del Regno, Bjorn Helgaas, Conor Dooley,
	Jianjun Wang, Krzysztof Kozlowski, Krzysztof Wilczyński,
	Lorenzo Bianconi, Lorenzo Pieralisi, Manivannan Sadhasivam,
	Matthias Brugger, Rob Herring, Ryder Lee, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek, linux-pci

On Wed, Sep 25, 2024 at 06:57:46PM +0800, Fei Shao wrote:
> In MediaTek PCIe gen3 bindings, "clocks" accepts a range of 1-6 clocks
> across all SoCs. But in practice, each SoC requires a particular number
> of clocks as defined in "clock-names", and the length of "clocks" and
> "clock-names" can be inconsistent with current bindings.
> 
> For example:
> - MT8188, MT8192 and MT8195 all require 6 clocks, while the bindings
>   accept 4-6 clocks.
> - MT7986 requires 4 clocks, while the bindings accept 4-6 clocks.
> 
> Update minItems and maxItems properties for individual SoCs as needed to
> only accept the correct number of clocks.
> 
> Fixes: c6abd0eadec6 ("dt-bindings: PCI: mediatek-gen3: Add support for Airoha EN7581")
> Signed-off-by: Fei Shao <fshao@chromium.org>

This patch only applied to pci/dt-bindings with Krzysztof K's
reviewed-by for v6.13, thank you!

> ---
> 
>  .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml          | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 898c1be2d6a4..f05aab2b1add 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -149,7 +149,7 @@ allOf:
>      then:
>        properties:
>          clocks:
> -          minItems: 4
> +          minItems: 6
>  
>          clock-names:
>            items:
> @@ -178,7 +178,7 @@ allOf:
>      then:
>        properties:
>          clocks:
> -          minItems: 4
> +          minItems: 6
>  
>          clock-names:
>            items:
> @@ -207,6 +207,7 @@ allOf:
>        properties:
>          clocks:
>            minItems: 4
> +          maxItems: 4
>  
>          clock-names:
>            items:
> -- 
> 2.46.0.792.g87dc391469-goog
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-10-02 20:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-25 10:57 [PATCH 0/6] MT8188 DT and binding fixes Fei Shao
2024-09-25 10:57 ` [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only Fei Shao
2024-09-25 13:59   ` Krzysztof Kozlowski
2024-10-01 19:53   ` Bjorn Helgaas
2024-10-02  3:35     ` Fei Shao
2024-10-02 20:31   ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).