From: okaya@codeaurora.org
To: Lukas Wunner <lukas@wunner.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Yehezkel Bernat <yehezkel.bernat@intel.com>,
Michael Jamet <michael.jamet@intel.com>,
linux-pci@vger.kernel.org
Subject: Re: Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown
Date: Sat, 13 Jan 2018 15:49:22 -0500 [thread overview]
Message-ID: <6c512cea0c089427958b8768e6296bb3@codeaurora.org> (raw)
In-Reply-To: <20180113193931.GA3585@wunner.de>
On 2018-01-13 14:39, Lukas Wunner wrote:
> On Sat, Jan 13, 2018 at 12:58:53PM -0500, okaya@codeaurora.org wrote:
>> I waa thinking of using nowait variant of write function in
>> notification
>> disable function in order to not introduce new behavior for existing
>> silicon.
>
> After writing to the Slot Control register to turn off IRQ
> notification,
> we free the IRQ with pciehp_free_irq(). If we don't wait for the
> command
> to complete, we risk getting an interrupt after the IRQ was freed.
>
Yeah, that is true.
next prev parent reply other threads:[~2018-01-13 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 10:49 Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown Lukas Wunner
2018-01-12 11:03 ` Lukas Wunner
2018-01-12 14:26 ` Sinan Kaya
2018-01-12 15:12 ` Lukas Wunner
2018-01-12 15:31 ` Sinan Kaya
2018-01-13 7:32 ` Lukas Wunner
2018-01-13 17:58 ` okaya
2018-01-13 19:39 ` Lukas Wunner
2018-01-13 20:49 ` okaya [this message]
2018-01-12 16:34 ` Mika Westerberg
2018-01-13 7:14 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c512cea0c089427958b8768e6296bb3@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox