Re: [PATCH] ACPI: Remove trailing whitespace

Maximilian Luz
2020-11-04T17:37:15Z

On 11/4/20 6:12 PM, Joe Perches wrote:

[...]

>> I'm not too sure about the comments, but I can find the time to look
>> over the output and adjust that if that's something you'd want me to do.
>
> Up to you. I hardly looked at the output.
>
> I'd generally prefer to use a single line comment like
>
> /* AC Adapter Management */
>
> but I don't know how often that dashed block is used in ACPI.
>
> grep seems to show the texts are not correctly centered so it seems like
> it was done by hand and not that some automation tool was used to create
> those blocks.
>
> Maybe a separate patch could be done to change those if desired.
> But not by me.

I'm hesitant to touch those, mostly as you said because they're
subjective (and I don't really see any big issues with them). Seems to
be the prevalent style in the drivers/acpi, although there are other
block-like separator comments at least in drivers/acpi/dock.c.

> As far as I know, acpi was once autogenerated from a common source tree
> and whitespace changes were once frowned on, but maybe that's changed or
> or perhaps that's only for files in drivers/acpi/acpica/. I don't know.
>
> https://acpica.org/downloads/linux

Yeah, any changes to drivers/acpi/acpica would have to go through their
repo.

I'll go over the checkpatch output later and prepare a v2 that doesn't
touch the comments, unless anyone has any issues with that.

Regards,
Max