Re: [PATCH] ACPI: Remove trailing whitespace

Maximilian Luz
2020-11-04T15:48:15Z

On 11/4/20 6:13 AM, Joe Perches wrote:

[...]

>> Yes. I scanned drivers/acpi for trailing whitespaces after I noticed a
>> couple of them. I did not explicitly scan for other stuff like spaces
>> where there should be tabs, mostly because I haven't found a quick and
>> reliable solution for that. I only noticed an inconsistent indentation
>> when committing, so I fixed that too.
>
> You could try:
>
> $ git ls-files -- 'drivers/acpi/*.[ch]' | \
> xargs ./scripts/checkpatch.pl -f --fix-inplace --types=CODE_INDENT

Thanks, that indeed looks like a decent solution.

> Right now that produces:
> ---

[...]

> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 46a64e9fa716..46be80976a03 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -89,7 +89,7 @@ struct acpi_ac {
> #define to_acpi_ac(x) power_supply_get_drvdata(x)
>
> /* --------------------------------------------------------------------------
> - AC Adapter Management
> + AC Adapter Management
> -------------------------------------------------------------------------- */

I'm not too sure about the comments, but I can find the time to look
over the output and adjust that if that's something you'd want me to do.

Regards,
Max