From: Hanjie Lin <hanjie.lin@amlogic.com>
To: Dan Carpenter <dan.carpenter@oracle.com>, <kbuild@01.org>
Cc: <kbuild-all@01.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Yue Wang <yue.wang@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Rob Herring <robh@kernel.org>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Cyrille Pitchen <cyrille.pitchen@free-electrons.com>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
Yixun Lan <yixun.lan@amlogic.com>,
Liang Yang <liang.yang@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Qiufang Dai <qiufang.dai@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>
Subject: Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver
Date: Thu, 29 Nov 2018 20:08:57 +0800 [thread overview]
Message-ID: <6da0ecdc-47e6-960e-c84e-2eb30632c317@amlogic.com> (raw)
In-Reply-To: <20181129090340.GO3073@unbuntlaptop>
On 2018/11/29 17:03, Dan Carpenter wrote:
> Hi Yue,
>
> url: https://github.com/0day-ci/linux/commits/Hanjie-Lin/dt-bindings-PCI-meson-add-DT-bindings-for-Amlogic-Meson-PCIe-controller/20181122-225955
> base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
>
> smatch warnings:
> drivers/pci/controller/dwc/pci-meson.c:171 meson_pcie_get_mem_shared() error: passing non negative 6 to ERR_PTR
>
> # https://github.com/0day-ci/linux/commit/c882cdc75e49b6de65cd3d95ebf688272af6b5f9
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout c882cdc75e49b6de65cd3d95ebf688272af6b5f9
> vim +171 drivers/pci/controller/dwc/pci-meson.c
>
> c882cdc75 Yue Wang 2018-11-22 160
> c882cdc75 Yue Wang 2018-11-22 161 static void __iomem *meson_pcie_get_mem_shared(struct platform_device *pdev,
> c882cdc75 Yue Wang 2018-11-22 162 struct meson_pcie *mp,
> c882cdc75 Yue Wang 2018-11-22 163 const char *id)
> c882cdc75 Yue Wang 2018-11-22 164 {
> c882cdc75 Yue Wang 2018-11-22 165 struct device *dev = mp->pci.dev;
> c882cdc75 Yue Wang 2018-11-22 166 struct resource *res;
> c882cdc75 Yue Wang 2018-11-22 167
> c882cdc75 Yue Wang 2018-11-22 168 res = platform_get_resource_byname(pdev, IORESOURCE_MEM, id);
> c882cdc75 Yue Wang 2018-11-22 169 if (!res) {
> c882cdc75 Yue Wang 2018-11-22 170 dev_err(dev, "No REG resource %s\n", id);
> c882cdc75 Yue Wang 2018-11-22 @171 return ERR_PTR(ENXIO);
> ^^^^^
> -ENXIO
>
> c882cdc75 Yue Wang 2018-11-22 172 }
> c882cdc75 Yue Wang 2018-11-22 173
> c882cdc75 Yue Wang 2018-11-22 174 return devm_ioremap(dev, res->start, resource_size(res));
> c882cdc75 Yue Wang 2018-11-22 175 }
> c882cdc75 Yue Wang 2018-11-22 176
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
> .
>
Yes, it's really a silly mistake.
I'll fix it.
thanks.
next prev parent reply other threads:[~2018-11-29 12:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 8:53 [PATCH v6 0/2] add the Amlogic Meson PCIe controller driver Hanjie Lin
2018-11-22 8:53 ` [PATCH v6 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller Hanjie Lin
2018-11-22 8:53 ` [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver Hanjie Lin
2018-11-29 9:03 ` Dan Carpenter
2018-11-29 12:08 ` Hanjie Lin [this message]
2018-11-29 12:20 ` Dan Carpenter
2018-12-03 16:41 ` Lorenzo Pieralisi
2018-12-03 22:57 ` Bjorn Helgaas
2018-12-04 10:40 ` Hanjie Lin
2018-12-04 12:00 ` Lorenzo Pieralisi
2018-12-05 9:55 ` Hanjie Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6da0ecdc-47e6-960e-c84e-2eb30632c317@amlogic.com \
--to=hanjie.lin@amlogic.com \
--cc=bhelgaas@google.com \
--cc=carlo@caione.org \
--cc=cyrille.pitchen@free-electrons.com \
--cc=dan.carpenter@oracle.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pombredanne@nexb.com \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=yixun.lan@amlogic.com \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).