From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Cc: Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
Hans de Goede <hansg@kernel.org>,
Mark Pearson <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kbuild@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-pm@vger.kernel.org,
Stephan Gerhold <stephan.gerhold@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH 3/9] serdev: Allow passing the serdev device name to serdev_device_add()
Date: Tue, 18 Nov 2025 11:41:37 +0200 (EET) [thread overview]
Message-ID: <7053dfed-5eff-7182-bc85-0437a4074c82@linux.intel.com> (raw)
In-Reply-To: <20251112-pci-m2-e-v1-3-97413d6bf824@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 5682 bytes --]
On Wed, 12 Nov 2025, Manivannan Sadhasivam via B4 Relay wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>
> Instead of always setting the serdev device name from 'struct device' name,
> allow the callers to pass an optional name and set it as the serdev device
> name.
>
> This will be used by the future callers passing the serdev device ID as the
> name.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> ---
> drivers/platform/x86/dell/dell-uart-backlight.c | 2 +-
> .../platform/x86/lenovo/yoga-tab2-pro-1380-fastcharger.c | 2 +-
> drivers/platform/x86/x86-android-tablets/core.c | 2 +-
> drivers/tty/serdev/core.c | 13 +++++++++----
> include/linux/serdev.h | 2 +-
> 5 files changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/dell-uart-backlight.c b/drivers/platform/x86/dell/dell-uart-backlight.c
> index f323a667dc2d2c7dec9fb284515bc3b6b984b7b9..f076cfac2bc5ec14899d6622d084bae2ffecfa3c 100644
> --- a/drivers/platform/x86/dell/dell-uart-backlight.c
> +++ b/drivers/platform/x86/dell/dell-uart-backlight.c
> @@ -354,7 +354,7 @@ static int dell_uart_bl_pdev_probe(struct platform_device *pdev)
> if (!serdev)
> return -ENOMEM;
>
> - ret = serdev_device_add(serdev);
> + ret = serdev_device_add(serdev, NULL);
> if (ret) {
> dev_err(&pdev->dev, "error %d adding serdev\n", ret);
> serdev_device_put(serdev);
> diff --git a/drivers/platform/x86/lenovo/yoga-tab2-pro-1380-fastcharger.c b/drivers/platform/x86/lenovo/yoga-tab2-pro-1380-fastcharger.c
> index 8551ab4d2c7dbc3a8d0b2f50071d4460a3ee65e9..5e568fe1162d1563183713f8d5c71c59ff7667a1 100644
> --- a/drivers/platform/x86/lenovo/yoga-tab2-pro-1380-fastcharger.c
> +++ b/drivers/platform/x86/lenovo/yoga-tab2-pro-1380-fastcharger.c
> @@ -260,7 +260,7 @@ static int yt2_1380_fc_pdev_probe(struct platform_device *pdev)
> /* The fwnode is a managed node, so it will be auto-put on serdev_device_put() */
> fwnode_handle_get(dev_fwnode(&serdev->dev));
>
> - ret = serdev_device_add(serdev);
> + ret = serdev_device_add(serdev, NULL);
> if (ret) {
> serdev_device_put(serdev);
> return dev_err_probe(&pdev->dev, ret, "adding serdev\n");
> diff --git a/drivers/platform/x86/x86-android-tablets/core.c b/drivers/platform/x86/x86-android-tablets/core.c
> index 6588fae303562b7dc9a1a8d281b167e44f0d3e84..96140f5d4f79240f44cb4530ee63777f783c6aaf 100644
> --- a/drivers/platform/x86/x86-android-tablets/core.c
> +++ b/drivers/platform/x86/x86-android-tablets/core.c
> @@ -316,7 +316,7 @@ static __init int x86_instantiate_serdev(const struct x86_dev_info *dev_info, in
> ACPI_COMPANION_SET(&serdev->dev, serdev_adev);
> acpi_device_set_enumerated(serdev_adev);
>
> - ret = serdev_device_add(serdev);
> + ret = serdev_device_add(serdev, NULL);
> if (ret) {
> dev_err(&serdev->dev, "error %d adding serdev\n", ret);
> serdev_device_put(serdev);
> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> index 2b5582cd5063a87c9a6c99f83a8ab071637eae57..76b89dd0720f89dbe34e205b905ef24d9f94d770 100644
> --- a/drivers/tty/serdev/core.c
> +++ b/drivers/tty/serdev/core.c
> @@ -121,14 +121,19 @@ static int serdev_device_match(struct device *dev, const struct device_driver *d
> /**
> * serdev_device_add() - add a device previously constructed via serdev_device_alloc()
> * @serdev: serdev_device to be added
> + * @name: name of the serdev device (optional)
> */
> -int serdev_device_add(struct serdev_device *serdev)
> +int serdev_device_add(struct serdev_device *serdev, const char *name)
> +
> {
> struct serdev_controller *ctrl = serdev->ctrl;
> struct device *parent = serdev->dev.parent;
> int err;
>
> - dev_set_name(&serdev->dev, "%s-%d", dev_name(parent), serdev->nr);
> + if (name)
> + dev_set_name(&serdev->dev, "%s", name);
> + else
> + dev_set_name(&serdev->dev, "%s-%d", dev_name(parent), serdev->nr);
>
> /* Only a single slave device is currently supported. */
> if (ctrl->serdev) {
> @@ -544,7 +549,7 @@ static int of_serdev_register_devices(struct serdev_controller *ctrl)
>
> device_set_node(&serdev->dev, of_fwnode_handle(node));
>
> - err = serdev_device_add(serdev);
> + err = serdev_device_add(serdev, NULL);
> if (err) {
> dev_err(&serdev->dev,
> "failure adding device. status %pe\n",
> @@ -692,7 +697,7 @@ static acpi_status acpi_serdev_register_device(struct serdev_controller *ctrl,
> ACPI_COMPANION_SET(&serdev->dev, adev);
> acpi_device_set_enumerated(adev);
>
> - err = serdev_device_add(serdev);
> + err = serdev_device_add(serdev, NULL);
> if (err) {
> dev_err(&serdev->dev,
> "failure adding ACPI serdev device. status %pe\n",
> diff --git a/include/linux/serdev.h b/include/linux/serdev.h
> index ee42e293445d928a311bd3c120e609214f89a5dd..3b87909b199af74d619b4fe548c5c9c994e7bc15 100644
> --- a/include/linux/serdev.h
> +++ b/include/linux/serdev.h
> @@ -163,7 +163,7 @@ static inline void serdev_controller_put(struct serdev_controller *ctrl)
> }
>
> struct serdev_device *serdev_device_alloc(struct serdev_controller *);
> -int serdev_device_add(struct serdev_device *);
> +int serdev_device_add(struct serdev_device *serdev, const char *name);
> void serdev_device_remove(struct serdev_device *);
>
> struct serdev_controller *serdev_controller_alloc(struct device *host,
>
>
Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2025-11-18 9:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 14:45 [PATCH 0/9] Add support for handling PCIe M.2 Key E connectors in devicetree Manivannan Sadhasivam via B4 Relay
2025-11-12 14:45 ` [PATCH 1/9] serdev: Convert to_serdev_device() and to_serdev_controller() helpers to macros Manivannan Sadhasivam via B4 Relay
2025-11-12 21:13 ` Rob Herring
2025-11-13 5:15 ` Manivannan Sadhasivam
2025-11-12 14:45 ` [PATCH 2/9] serdev: Add serdev device based driver match support Manivannan Sadhasivam via B4 Relay
2025-11-12 14:45 ` [PATCH 3/9] serdev: Allow passing the serdev device name to serdev_device_add() Manivannan Sadhasivam via B4 Relay
2025-11-18 9:41 ` Ilpo Järvinen [this message]
2025-11-12 14:45 ` [PATCH 4/9] serdev: Add an API to find the serdev controller associated with the devicetree node Manivannan Sadhasivam via B4 Relay
2025-11-12 14:45 ` [PATCH 5/9] serdev: Add modalias support for serdev client devices Manivannan Sadhasivam via B4 Relay
2025-11-12 14:45 ` [PATCH 6/9] serdev: Skip registering serdev devices from DT is external connector is used Manivannan Sadhasivam via B4 Relay
2025-11-18 13:03 ` Rob Herring
2025-11-19 13:32 ` Manivannan Sadhasivam
2025-11-20 16:22 ` Rob Herring
2025-11-20 16:54 ` Manivannan Sadhasivam
2025-11-12 14:45 ` [PATCH 7/9] dt-bindings: connector: Add PCIe M.2 Mechanical Key E connector Manivannan Sadhasivam via B4 Relay
2025-11-12 17:11 ` Frank Li
2025-11-13 5:00 ` Manivannan Sadhasivam
2025-11-19 23:59 ` Rob Herring
2025-11-20 12:57 ` Manivannan Sadhasivam
2025-11-12 20:08 ` Dmitry Baryshkov
2025-11-13 5:05 ` Manivannan Sadhasivam
2025-11-12 14:45 ` [PATCH 8/9] Bluetooth: hci_qca: Add support for WCN7850 PCIe M.2 card Manivannan Sadhasivam via B4 Relay
2025-11-18 14:29 ` Bartosz Golaszewski
2025-11-19 13:36 ` Manivannan Sadhasivam
2025-11-12 14:45 ` [PATCH 9/9] power: sequencing: pcie-m2: Add support for PCIe M.2 Key E connectors Manivannan Sadhasivam via B4 Relay
2025-11-19 13:28 ` Bartosz Golaszewski
2025-11-19 13:54 ` Manivannan Sadhasivam
2025-11-12 21:07 ` [PATCH 0/9] Add support for handling PCIe M.2 Key E connectors in devicetree Rob Herring
2025-11-13 5:13 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7053dfed-5eff-7182-bc85-0437a4074c82@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=derekjohn.clark@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=marcel@holtmann.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=nathan@kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).