From: Hinko Kocevar <hinko.kocevar@ess.eu>
To: Keith Busch <kbusch@kernel.org>,
"Kelley, Sean V" <sean.v.kelley@intel.com>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCHv2 0/5] aer handling fixups
Date: Fri, 8 Jan 2021 10:38:08 +0100 [thread overview]
Message-ID: <70f2288d-2d1e-df82-d107-e977e1f50dca@ess.eu> (raw)
In-Reply-To: <20210107214236.GA1284006@dhcp-10-100-145-180.wdc.com>
On 1/7/21 10:42 PM, Keith Busch wrote:
> On Tue, Jan 05, 2021 at 11:07:23PM +0000, Kelley, Sean V wrote:
>>> On Jan 5, 2021, at 10:33 AM, Keith Busch <kbusch@kernel.org> wrote:
>>> On Tue, Jan 05, 2021 at 04:06:53PM +0100, Hinko Kocevar wrote:
>>>> On 1/5/21 3:21 PM, Hinko Kocevar wrote:
>>>>> On 1/5/21 12:02 AM, Keith Busch wrote:
>>>>>> Changes from v1:
>>>>>>
>>>>>> Added received Acks
>>>>>>
>>>>>> Split the kernel print identifying the port type being reset.
>>>>>>
>>>>>> Added a patch for the portdrv to ensure the slot_reset happens without
>>>>>> relying on a downstream device driver..
>>>>>>
>>>>>> Keith Busch (5):
>>>>>> PCI/ERR: Clear status of the reporting device
>>>>>> PCI/AER: Actually get the root port
>>>>>> PCI/ERR: Retain status from error notification
>>>>>> PCI/AER: Specify the type of port that was reset
>>>>>> PCI/portdrv: Report reset for frozen channel
>>>>
>>>> I removed the patch 5/5 from this patch series, and after testing again, it
>>>> makes my setup recover from the injected error; same as observed with v1
>>>> series.
>>>
>>> Thanks for the notice. Unfortunately that seems even more confusing to
>>> me right now. That patch shouldn't do anything to the devices or the
>>> driver's state; it just ensures a recovery path that was supposed to
>>> happen anyway. The stack trace says restoring the config space completed
>>> partially before getting stuck at the virtual channel capability, at
>>> which point it appears to be in an infinite loop. I'll try to look into
>>> it. The emulated devices I test with don't have the VC cap but I might
>>> have real devices that do.
>>
>> I’m not seeing the error either with V2 when testing with are-inject using RCECs and an associated RCiEP.
>
> Thank you, yes, I'm also not seeing a problem either on my end. The
> sighting is still concerning though, so I'll keep looking. I may have to
> request Hinko to try a debug patch to help narrow down where things have
> gone wrong if that's okay.
>
Sure. I'm willing to help out and debug this on my side as well. Let me
know what you need me to do!
next prev parent reply other threads:[~2021-01-08 9:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 23:02 [PATCHv2 0/5] aer handling fixups Keith Busch
2021-01-04 23:02 ` [PATCHv2 1/5] PCI/ERR: Clear status of the reporting device Keith Busch
2021-01-04 23:02 ` [PATCHv2 2/5] PCI/AER: Actually get the root port Keith Busch
2021-01-04 23:02 ` [PATCHv2 3/5] PCI/ERR: Retain status from error notification Keith Busch
2021-03-03 5:34 ` Williams, Dan J
2021-03-03 5:46 ` Kuppuswamy, Sathyanarayanan
2021-03-04 20:01 ` Keith Busch
2021-03-04 22:11 ` Dan Williams
[not found] ` <23551edc-965c-21dc-0da8-a492c27c362d@intel.com>
2021-03-04 22:59 ` Dan Williams
2021-03-04 23:19 ` Kuppuswamy, Sathyanarayanan
2021-03-05 0:23 ` Dan Williams
2021-03-05 0:54 ` Keith Busch
2021-01-04 23:02 ` [PATCHv2 4/5] PCI/AER: Specify the type of port that was reset Keith Busch
2021-01-04 23:03 ` [PATCHv2 5/5] PCI/portdrv: Report reset for frozen channel Keith Busch
2021-01-05 14:21 ` [PATCHv2 0/5] aer handling fixups Hinko Kocevar
2021-01-05 15:06 ` Hinko Kocevar
2021-01-05 18:33 ` Keith Busch
2021-01-05 23:07 ` Kelley, Sean V
2021-01-07 21:42 ` Keith Busch
2021-01-08 9:38 ` Hinko Kocevar [this message]
2021-01-11 13:39 ` Hinko Kocevar
2021-01-11 16:37 ` Keith Busch
2021-01-11 20:02 ` Hinko Kocevar
2021-01-11 22:09 ` Keith Busch
[not found] ` <ed8256dd-d70d-b8dc-fdc0-a78b9aa3bbd9@ess.eu>
2021-01-12 19:27 ` Keith Busch
2021-01-12 22:19 ` Hinko Kocevar
2021-01-12 23:17 ` Keith Busch
2021-01-18 8:00 ` Hinko Kocevar
2021-01-19 18:28 ` Keith Busch
2021-02-03 0:03 ` Keith Busch
2021-02-04 8:35 ` Hinko Kocevar
2021-02-08 12:55 ` Hedi Berriche
2021-02-09 23:06 ` Bjorn Helgaas
2021-02-10 4:05 ` Keith Busch
2021-02-10 21:38 ` Bjorn Helgaas
2021-02-10 9:36 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70f2288d-2d1e-df82-d107-e977e1f50dca@ess.eu \
--to=hinko.kocevar@ess.eu \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sean.v.kelley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox