From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7461537D133; Thu, 6 Aug 2026 16:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786035039; cv=none; b=EJPfD03IUNe2NtzDePbcw5tG2a7dGspXH0s9lTZCqJytTKM+OmNxfae4IF9zRyC3LJ2kagMDb4fKv9TIdyBwkco0AzaNxOE1vteH7idG4QJ8uisGn0Aen1W4Cr0PJMI7N/rydpyp5O3RWPdWpg2lhl05Duc+VRZYB2GQLdDFKrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786035039; c=relaxed/simple; bh=dgojdZlq0aFZ2udUsDeqEs8qOj+jZTbzbnvUb+gaBks=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LRWwb2m1i6bt5zFudbOIvaCmU23osU2CwYOW66Bw+Pj8o3a5hTU9709Zb4pLhRnbYu3Wzy5uIQyGP/6JVk9QMuWm1q1gnjH6BPCYEidv8h7TA+zUWdDvX6fRIqXbUaC4igi2+uGfiLcDwYZl2p5SlmU+dB8huyICoG3hRo8AZZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=PWgW/xsI; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="PWgW/xsI" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 676EnA1b2939527; Thu, 6 Aug 2026 16:50:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=dI/JUW OXVfmk03QoibAP+70rE2yFJwykSpSDH95V5/w=; b=PWgW/xsI4pebgAH/BV1kz8 PrYpd0TU18Kia8wtq8jNczblGnJT/lUvsuDMqLGrIaUzrXtht7DadTOtm4lj/qni m0P8s1ENRkiLbGPy/n9Z8COsJwxLX2UopugiFKvIKg6TPEWepo0IXQ669a7grjwB cp4t90+FIFaG9AWMHBmV4UpXr93ak5TjfjsH3BqSKb+78bV45ydLtW28McSyON2o dHCKK5TvclBcyZ+FCsCShJFdSahmvkmqB0RF0Aufvki2M31Jra3lJpp/e1EaqUrG znpkB6gk97y7VWWEZlJDHtNGlSHjvbhLOki+2cau6+h9f6OzjuzRGpOQ9MMwxd3w == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fs8a49cn5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Aug 2026 16:50:15 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 676GfRJL018806; Thu, 6 Aug 2026 16:50:14 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4fswtyutnm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Aug 2026 16:50:14 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 676Go8OS30933476 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 Aug 2026 16:50:08 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C1C3120043; Thu, 6 Aug 2026 16:50:08 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 11FB120040; Thu, 6 Aug 2026 16:50:04 +0000 (GMT) Received: from [9.67.65.218] (unknown [9.67.65.218]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 6 Aug 2026 16:50:03 +0000 (GMT) Message-ID: <72ce5fa7-d12b-40e5-a4a2-f2de414088d1@linux.ibm.com> Date: Thu, 6 Aug 2026 22:20:02 +0530 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: quirks: Add warm reset quirk for IBM Spyre accelerator To: Bjorn Helgaas , Avinash Roy Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, bhelgaas@google.com, npiggin@gmail.com, chleroy@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Avinash Roy References: <20260805171840.GA2126423@bhelgaas> Content-Language: en-US From: Shivaprasad G Bhat In-Reply-To: <20260805171840.GA2126423@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=E6P9Y6dl c=1 sm=1 tr=0 ts=6a74bb47 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=lNBmhb5rY3KJr28suEEA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: A9CrAhuigwKofBxmnfCcLJ4S9jqP9RFJ X-Proofpoint-GUID: LvFnR9t07Rol95n-wE_uOh-qTWiH2Xy5 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA2MDEzMSBTYWx0ZWRfX0srVlo17IyM8 GCHvlg1eoQf97TwPNmj+IylyERYu1FuQTYWGmHs50pmU+6n2tg6c0oSLjGXSbrhEoHYhQWc8VOv UdNoe+xstgmTo7URo3sFwRlW3YQecTw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA2MDEzMSBTYWx0ZWRfX30k6tIyX9/0Y hVu7CVXerDNsdRZJrSmUneKKfa3juUzkXerZqx+WirCXg/F2vfcpx/mY1HSK3ova3muZyDR+S+F Hq53TLO/FazxXFQ1hKKGINeRxJjurSA0g4u6B4gKjT1k1+nlTOfqFz86ySi0yrrXU6YMieGduQo x25UeGLgZEHHkyAN2JELunV5ridXnuO7zLv2jC+w4PAC4xiQ1mZ8RWf500JGH0wpo9oepIb+itM q4jeQxrN5bKhwDMo1uibRRPtQv7MxJ79gUWPpT159LewXCX9mOBanP/NSt9wRq2ORzrZklPlBs/ /j6m+PYBpXFS7sXl9Hdci90tFoZbshL0efZPKuygf+odI70Aj/9HPk0ymazRuXVcKTCPJpF9JLG ChLELbKXInS8PqDr2ydbS3F0C+i6oxT6A7/2NsoDXQw/4ANKvXqh2OZzUDwcnsPlWCo6Yjh+iAj CXRbGxkcql8Y62t3I6w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-06_01,2026-08-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1011 lowpriorityscore=0 priorityscore=1501 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608060131 Hi Bjorn, Thanks for taking a look. On 8/5/26 10:48 PM, Bjorn Helgaas wrote: > On Wed, Aug 05, 2026 at 06:21:32PM +0530, Avinash Roy wrote: >> From: Shivaprasad G Bhat >> >> The IBM Spyre accelerator (PCI ID 1014:06a7) requires a dedicated warm >> reset method for reliable EEH recovery on pSeries/ppc64 platforms. >> >> FLR alone is insufficient because it does not re-initialize the Spyre >> firmware state machine. On ppc64 with EEH enabled, >> pcibios_set_pcie_reset_state() is overridden in >> arch/powerpc/kernel/eeh.c to drive the platform-level PERST# signal via >> EEH PE operations, which is the correct mechanism for full device >> recovery after an EEH event. > > This makes it sound like this mechanism is needed for EEH recovery for > *all* devices, not just Spyre. If that's the case it sounds like we > need more than just a Spyre-specific quirk. Now I re-read it, The second statement needs to be re-worded. It does sound like its true for all devices. Quirk is only for the Spyre card. Will post a v2 fixing the same. Thanks and Regards, Shivaprasad > >> The reset function is placed in arch/powerpc/platforms/pseries/pci.c >> where the EEH infrastructure is already present, declared in >> pseries.h, and registered in the generic pci_dev_reset_methods[] table >> in drivers/pci/quirks.c under a CONFIG_PPC_PSERIES guard. >> >> This reset method is only registered when CONFIG_PPC_PSERIES is enabled, >> so it is not available on other platforms. >> >> Reset sequence: >> - Assert PERST# via pcie_warm_reset, hold 250 ms >> - Deassert PERST# via pcie_deassert_reset >> - Wait 250 ms for PCIe link retrain and device recovery >> >> Signed-off-by: Avinash Roy >> Signed-off-by: Shivaprasad G Bhat >> ---