From: Heiko Stuebner <heiko@sntech.de>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
Brian Norris <briannorris@chromium.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add three new resets for rk3399 PCIe controller
Date: Fri, 21 Oct 2016 09:58:11 +0200 [thread overview]
Message-ID: <7351283.vgsyxVQ7sJ@phil> (raw)
In-Reply-To: <1477017836-19317-3-git-send-email-shawn.lin@rock-chips.com>
Hi Bjorn,
Am Freitag, 21. Oktober 2016, 10:43:56 CEST schrieb Shawn Lin:
> pm_rst, aclk_rst and pclk_rst should be controlled by driver, so we
> need to add these three resets for PCIe controller.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
If patch1 is ok and you want to take both patches at once,
that is fine by me, so
Acked-by: Heiko Stuebner <heiko@sntech.de>
Otherwise I can also pick this one up after (and if) your ok with patch1.
Heiko
> ---
>
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 76b2864..5191cfd 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -300,8 +300,11 @@
> ranges = <0x83000000 0x0 0xfa000000 0x0 0xfa000000 0x0 0x600000
> 0x81000000 0x0 0xfa600000 0x0 0xfa600000 0x0 0x100000>;
> resets = <&cru SRST_PCIE_CORE>, <&cru SRST_PCIE_MGMT>,
> - <&cru SRST_PCIE_MGMT_STICKY>, <&cru SRST_PCIE_PIPE>;
> - reset-names = "core", "mgmt", "mgmt-sticky", "pipe";
> + <&cru SRST_PCIE_MGMT_STICKY>, <&cru SRST_PCIE_PIPE>,
> + <&cru SRST_PCIE_PM>, <&cru SRST_P_PCIE>,
> + <&cru SRST_A_PCIE>;
> + reset-names = "core", "mgmt", "mgmt-sticky", "pipe",
> + "pm", "pclk", "aclk";
> status = "disabled";
>
> pcie0_intc: interrupt-controller {
next prev parent reply other threads:[~2016-10-21 7:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 2:43 [PATCH 0/2] Add new resets for pcie-rockchip Shawn Lin
2016-10-21 2:43 ` [PATCH 1/2] PCI: rockchip: Add three new resets as required properties Shawn Lin
2016-10-21 7:56 ` Heiko Stuebner
2016-10-27 14:54 ` Rob Herring
2016-10-21 2:43 ` [PATCH 2/2] arm64: dts: rockchip: add three new resets for rk3399 PCIe controller Shawn Lin
2016-10-21 7:58 ` Heiko Stuebner [this message]
2016-11-09 0:05 ` [PATCH 0/2] Add new resets for pcie-rockchip Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7351283.vgsyxVQ7sJ@phil \
--to=heiko@sntech.de \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox