From: Niklas Cassel <cassel@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: qcom-ep: Set intx_capable in epc_features
Date: Wed, 02 Apr 2025 18:43:21 +0200 [thread overview]
Message-ID: <755F7184-5076-40D6-9C74-FC1721BED16B@kernel.org> (raw)
In-Reply-To: <rkdzsql5vqk36wea5mvr34jz5t32jwleep7brigrgkuir3jlxy@qcbdb3pty7iq>
On 2 April 2025 18:34:28 CEST, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
>On Wed, Apr 02, 2025 at 11:16:28AM +0200, Niklas Cassel wrote:
>> While I do not have the technical reference manuals, the qcom-ep
>> maintainer assures me that all compatibles support generating INTx IRQs.
>>
>
>Yes, all Qcom EP controllers do support INTx.
>
>> Thus, set intx_capable to true in epc_features.
>>
>
>Hmm, this, I do not want to do atm. Qcom endpoints cannot raise INTx due to lack
>of the driver support. So setting this flag would imply that the INTx is
>functionally supported by the endpoint, but it is not.
>
>Atleast, 'pci_epc_features' is not a devicetree configuration, that it has to
>match what the hw supports instead of the driver support availability :)
Ok, I misunderstood then.
Let's just drop this patch.
Kind regards,
Niklas
prev parent reply other threads:[~2025-04-02 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 9:16 [PATCH] PCI: qcom-ep: Set intx_capable in epc_features Niklas Cassel
2025-04-02 14:22 ` Dmitry Baryshkov
2025-04-02 16:34 ` Manivannan Sadhasivam
2025-04-02 16:43 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=755F7184-5076-40D6-9C74-FC1721BED16B@kernel.org \
--to=cassel@kernel.org \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox