From: okaya@codeaurora.org
To: Lukas Wunner <lukas@wunner.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: Coccinelle report for drivers/pci/
Date: Tue, 03 Jul 2018 07:42:22 -0400 [thread overview]
Message-ID: <770c6adfdba8c02a2eeae336217b00d2@codeaurora.org> (raw)
In-Reply-To: <20180703080910.GB21136@wunner.de>
On 2018-07-03 04:09, Lukas Wunner wrote:
> On Mon, Jul 02, 2018 at 09:45:55PM -0400, Sinan Kaya wrote:
>> drivers/pci/hotplug/pciehp_pci.c:67:5-7: Unneeded variable: "rc".
>> Return "0" on line 110
>
> Fixed by
> https://patchwork.ozlabs.org/patch/930379/
>
>
>> drivers/pci/hotplug/pcihp_skeleton.c:98:5-11: Unneeded variable:
>> "retval". Return "0" on line 106
>> drivers/pci/hotplug/pcihp_skeleton.c:84:5-11: Unneeded variable:
>> "retval". Return "0" on line 92
>> drivers/pci/hotplug/pcihp_skeleton.c:201:5-11: Unneeded variable:
>> "retval". Return "0" on line 210
>> drivers/pci/hotplug/pcihp_skeleton.c:171:5-11: Unneeded variable:
>> "retval". Return "0" on line 180
>> drivers/pci/hotplug/pcihp_skeleton.c:186:5-11: Unneeded variable:
>> "retval". Return "0" on line 195
>> drivers/pci/hotplug/pcihp_skeleton.c:156:5-11: Unneeded variable:
>> "retval". Return "0" on line 165
>> drivers/pci/hotplug/pcihp_skeleton.c:137:5-11: Unneeded variable:
>> "retval". Return "0" on line 150
>> drivers/pci/hotplug/pcihp_skeleton.c:112:5-11: Unneeded variable:
>> "retval". Return "0" on line 131
>
> Fixed by 6c9c6bd4e2c8 ("PCI: hotplug: Delete skeleton driver"),
> queued on Bjorn's pci/hotplug branch for 4.19.
Thanks, glad to hear we are doing some house cleaning.
prev parent reply other threads:[~2018-07-03 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 1:45 Coccinelle report for drivers/pci/ Sinan Kaya
2018-07-03 8:09 ` Lukas Wunner
2018-07-03 11:42 ` okaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=770c6adfdba8c02a2eeae336217b00d2@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).