From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Problem with 4cec16861a40 ("PCI/ASPM: Convert to use match_string() helper")
Date: Fri, 03 Aug 2018 12:35:48 +0300 [thread overview]
Message-ID: <77e207877f5bf500a180cfdd7f23fe45669b27ea.camel@linux.intel.com> (raw)
In-Reply-To: <56e85d14-786d-02b9-b816-7e8c6cecc254@gmail.com>
On Thu, 2018-08-02 at 20:13 +0200, Heiner Kallweit wrote:
> I wondered why my system gets warmer than usual and eventually found
> that
> every write to /sys/module/pcie_aspm/parameters/policy returns EINVAL.
Thanks for spotting this!
My bad.
>
> Reason is mentioned change, using match_string() is wrong when used
> with
> sysfs because sysfs strings have a trailing newline.
Not always, but you are right, it has to be \n-aware.
> Seems like the patch
> wasn't tested.
> __sysfs_match_string() has to be used instead. I checked and this
> fixes
> the issue.
Yes, it should be sysfs variant.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2018-08-03 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 18:13 Problem with 4cec16861a40 ("PCI/ASPM: Convert to use match_string() helper") Heiner Kallweit
2018-08-03 9:35 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77e207877f5bf500a180cfdd7f23fe45669b27ea.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).