From: "Huang, Kai" <kai.huang@intel.com>
To: "leitao@debian.org" <leitao@debian.org>, "bp@alien8.de" <bp@alien8.de>
Cc: lkp <lkp@intel.com>,
"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
"xueshuai@linux.alibaba.com" <xueshuai@linux.alibaba.com>,
"acpica-devel@lists.linux.dev" <acpica-devel@lists.linux.dev>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"oohall@gmail.com" <oohall@gmail.com>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"osandov@osandov.com" <osandov@osandov.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"lenb@kernel.org" <lenb@kernel.org>,
"kernel-team@meta.com" <kernel-team@meta.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"mahesh@linux.ibm.com" <mahesh@linux.ibm.com>,
"guohanjun@huawei.com" <guohanjun@huawei.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"Moore, Robert" <robert.moore@intel.com>
Subject: Re: [PATCH v3] vmcoreinfo: Track and log recoverable hardware errors
Date: Wed, 23 Jul 2025 23:21:28 +0000 [thread overview]
Message-ID: <78760c59d6327585dcbd18ca51186c7860a47975.camel@intel.com> (raw)
In-Reply-To: <20250723190048.GBaIExYJYiHWnSBFye@renoirsky.local>
On Wed, 2025-07-23 at 21:00 +0200, Borislav Petkov wrote:
> On Wed, Jul 23, 2025 at 08:36:52AM -0700, Breno Leitao wrote:
> > Basically there are two approaches, from what I understand:
> >
> > 1) mark do_machine_check() as noinstr
>
> do_machine_check is already noinstr. I think you mean mark
> hwerr_log_error_type() noinstr.
>
> And yes, you can mark it. hwerr_log_error_type() is not that fascinating
> to allow instrumentation for it.
This option doesn't seem to be able to work because IIRC
hwerr_log_error_type() calls ktime_get_real_seconds() which is not
'noinstr'.
>
> > 2) Move hwerr_log_error_type() earlier inside the
> > instrumentation_begin() area.
>
> Or you can do that - that looks like less of an effort btw.
next prev parent reply other threads:[~2025-07-23 23:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 16:56 [PATCH v3] vmcoreinfo: Track and log recoverable hardware errors Breno Leitao
2025-07-23 14:28 ` kernel test robot
2025-07-23 15:36 ` Breno Leitao
2025-07-23 19:00 ` Borislav Petkov
2025-07-23 23:21 ` Huang, Kai [this message]
2025-07-24 8:00 ` Shuai Xue
2025-07-24 13:34 ` Breno Leitao
2025-07-25 7:40 ` Shuai Xue
2025-07-25 16:16 ` Breno Leitao
2025-07-28 1:08 ` Shuai Xue
2025-07-29 13:48 ` Breno Leitao
2025-07-30 2:13 ` Shuai Xue
2025-07-30 13:11 ` Breno Leitao
2025-07-30 13:50 ` Shuai Xue
2025-07-30 17:16 ` Breno Leitao
2025-07-30 16:21 ` Mauro Carvalho Chehab
2025-07-30 17:22 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78760c59d6327585dcbd18ca51186c7860a47975.camel@intel.com \
--to=kai.huang@intel.com \
--cc=acpica-devel@lists.linux.dev \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=guohanjun@huawei.com \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=kernel-team@meta.com \
--cc=konrad.wilk@oracle.com \
--cc=leitao@debian.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=mahesh@linux.ibm.com \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oohall@gmail.com \
--cc=osandov@osandov.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).