From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: "Ryder Lee" <ryder.lee@mediatek.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: mediatek-gen3: Add mediatek,pbus-csr phandle array property
Date: Mon, 24 Feb 2025 09:26:31 +0100 [thread overview]
Message-ID: <79809c37-84d4-42d6-ab93-9a9d29c687bf@kernel.org> (raw)
In-Reply-To: <Z7slEJgCQMqp_I6p@lore-desk>
On 23/02/2025 14:39, Lorenzo Bianconi wrote:
>> On Sat, Feb 22, 2025 at 11:43:44AM +0100, Lorenzo Bianconi wrote:
>>> Introduce the mediatek,pbus-csr property for the pbus-csr syscon node
>>> available on EN7581 SoC. The airoha pbus-csr block provides a configuration
>>> interface for the PBUS controller used to detect if a given address is
>>> accessible on PCIe controller.
>>>
>>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>>> ---
>>> .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 17 +++++++++++++++++
>>> 1 file changed, 17 insertions(+)
>>>
>>
>> You got review tag, so if you decided to skip it, this should be
>> mentioned why.
>>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Since I modified the patch with respect to the previous version, I was thinking
I know
> you want to review it again before applying the Reviewed-by tag. Added it now.
That was not my comment. I commented that you must explicitly say that
you dropped someone's tag.
And docs clearly ask for that:
"Usually removal of someone's Tested-by or Reviewed-by tags should be
mentioned in the patch changelog (after the '---' separator)."
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-24 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-22 10:43 [PATCH v3 0/2] PCI: mediatek-gen3: Set PBUS_CSR regs for Airoha EN7581 SoC Lorenzo Bianconi
2025-02-22 10:43 ` [PATCH v3 1/2] dt-bindings: PCI: mediatek-gen3: Add mediatek,pbus-csr phandle array property Lorenzo Bianconi
2025-02-23 9:43 ` Krzysztof Kozlowski
2025-02-23 13:39 ` Lorenzo Bianconi
2025-02-24 8:26 ` Krzysztof Kozlowski [this message]
2025-02-24 5:43 ` Manivannan Sadhasivam
2025-02-22 10:43 ` [PATCH v3 2/2] PCI: mediatek-gen3: Configure PBUS_CSR registers for EN7581 SoC Lorenzo Bianconi
2025-02-24 5:52 ` Manivannan Sadhasivam
2025-02-24 10:05 ` Lorenzo Bianconi
2025-02-24 13:18 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79809c37-84d4-42d6-ab93-9a9d29c687bf@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox