From: "Derrick, Jonathan" <jonathan.derrick@intel.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"helgaas@kernel.org" <helgaas@kernel.org>
Cc: "Kalakota, SushmaX" <sushmax.kalakota@intel.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: vmd: Keep fwnode allocated through VMD irqdomain life
Date: Tue, 14 Jul 2020 15:43:35 +0000 [thread overview]
Message-ID: <79a5df5e8c76c9af96e89d5c117d582d16e20874.camel@intel.com> (raw)
In-Reply-To: <87lfjmumtn.fsf@nanos.tec.linutronix.de>
On Tue, 2020-07-14 at 17:40 +0200, Thomas Gleixner wrote:
> "Derrick, Jonathan" <jonathan.derrick@intel.com> writes:
> > On Tue, 2020-06-30 at 11:33 -0500, Bjorn Helgaas wrote:
> > I see that struct irqchip_fwid contains the actual fwnode structure and
> > when that is freed, it's causes the issue.
> >
> > I'm noticing in each caller of irq_domain_free_fwnode, we have the
> > domain itself available. It seems like it should be up to the caller to
> > deal with the fwnode pointer, but we could just do:
>
> Why? The fwnode pointer handling is inconsistent for the various fwnode
> types.
I see... That does explain a lot.
> We really don't want to go back to that state.
>
> Thanks,
>
> tglx
Thanks for the prompt fix
Jon
next prev parent reply other threads:[~2020-07-14 15:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 16:24 [PATCH] PCI: vmd: Keep fwnode allocated through VMD irqdomain life Jon Derrick
2020-06-25 16:24 ` Jon Derrick
2020-06-25 19:58 ` Bjorn Helgaas
2020-06-25 20:21 ` Derrick, Jonathan
2020-06-29 23:20 ` Bjorn Helgaas
2020-06-30 9:39 ` Andy Shevchenko
2020-06-30 16:33 ` Bjorn Helgaas
2020-07-04 1:44 ` Derrick, Jonathan
2020-07-04 12:04 ` andriy.shevchenko
2020-07-14 15:40 ` Thomas Gleixner
2020-07-14 15:43 ` Derrick, Jonathan [this message]
2020-07-06 10:47 ` Thomas Gleixner
2020-07-06 11:18 ` Andy Shevchenko
2020-07-06 13:30 ` Thomas Gleixner
2020-07-06 15:44 ` Bjorn Helgaas
2020-07-09 9:53 ` [PATCH] irqdomain/treewide: Keep firmware node unconditionally allocated Thomas Gleixner
2020-07-09 12:00 ` Marc Zyngier
2020-07-09 21:47 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79a5df5e8c76c9af96e89d5c117d582d16e20874.camel@intel.com \
--to=jonathan.derrick@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=sushmax.kalakota@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).