From: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
To: Marek Vasut <marex@denx.de>
Cc: <linux-pci@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] [RFC] PCI/PM: Do not RPM suspend devices without drivers
Date: Mon, 28 Oct 2024 18:52:33 +0100 [thread overview]
Message-ID: <7ad59d82-8122-438e-9682-791816ab0366@intel.com> (raw)
In-Reply-To: <52b90ab1-2759-45e9-ae86-3d3073a0add0@denx.de>
On 10/26/2024 2:19 AM, Marek Vasut wrote:
> On 10/13/24 1:03 PM, Lukas Wunner wrote:
>> On Sat, Oct 12, 2024 at 02:48:48AM +0200, Marek Vasut wrote:
>>> The pci_host_probe() does reallocate BARs for devices which start up
>>> with
>>> uninitialized BAR addresses set to 0 by calling
>>> pci_bus_assign_resources(),
>>> which updates the device config space content.
>>>
>>> At the same time, pci_pm_runtime_suspend() triggers pci_save_state()
>>> for
>>> all devices which do not have drivers assigned to them to store current
>>> content of their config space registers.
What exactly do you mean by "at the same time"?
>> [...]
>>> Work around the issue by not suspending pci_bus_type devices which do
>>> not have driver assigned to them, keep those devices active to prevent
>>> pci_save_state() from being called. Once a proper driver takes over, it
>>> can RPM manage the device correctly.
>>
>> It sounds like you may want to acquire a runtime PM reference
>> or disable runtime PM for the duration of the bus scan (or at
>> least device scan) rather than the proposed workaround.
> I was hoping to get at least an confirmation that this issue really
> exists and that I'm not chasing some nonsense. Thoughts ?
next prev parent reply other threads:[~2024-10-28 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 0:48 [PATCH] [RFC] PCI/PM: Do not RPM suspend devices without drivers Marek Vasut
2024-10-12 0:59 ` Marek Vasut
2024-10-13 11:03 ` Lukas Wunner
2024-10-26 0:19 ` Marek Vasut
2024-10-28 17:52 ` Wysocki, Rafael J [this message]
2024-10-28 18:25 ` Marek Vasut
2024-10-29 18:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ad59d82-8122-438e-9682-791816ab0366@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=marex@denx.de \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox