From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C605C61DA7 for ; Thu, 26 Jan 2023 20:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230252AbjAZU5Z (ORCPT ); Thu, 26 Jan 2023 15:57:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbjAZU5Y (ORCPT ); Thu, 26 Jan 2023 15:57:24 -0500 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6F5D3433A for ; Thu, 26 Jan 2023 12:57:23 -0800 (PST) Received: by mail-il1-x134.google.com with SMTP id d10so1296089ilc.12 for ; Thu, 26 Jan 2023 12:57:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8q92vU6FC2OBfigvvadZc6pP7ck9MsJPPUZntKKUy/A=; b=DZqV6twI7VDtxWwtbB602B5SBi+EoZE3C2HyPq+uwbkahM3VPw1QtNWS7g9P5EEQQq 2P1Ij9Xwl4uzPzC/ZUT78vGXyyDU3nFU7OGsfm0KUkbBKPf2ZwK0Uv4fVQ8Mq40wiM8R ejCk3AqWm/XyADqZsr5wood3OyIU729juzb+U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8q92vU6FC2OBfigvvadZc6pP7ck9MsJPPUZntKKUy/A=; b=VZBMeS4KmuO1HYpeWn6QFR3ArdeSDBI/XAsRtA6ltTPaXg1PwgLoW0StroPeTdcVzo D62r9OMhw13h4meCEjckXK7UzLS6sAzWYl//2PuBJqOfOHQjAnza2s2AaNOKXWH6ksiO qWRFUxhaeJgb2mB6jH9MP8NPr6bakyfx4qs+0ZfV/FjjDtxtYL3GYHsndM7UxTckJWKe OrWTBz026DA6VWBCJjAybIjiPYxaG6ygLezmNOM1HQ6Yigm1yKWVkqZft4i7I8YCnefa KL+Vj+E35//YoxhPkcnVrNqn1/D32w0vs7iDVT0rk06fQ8AbHv0RJY3VXGaQzUdTXvcX 11Hg== X-Gm-Message-State: AO0yUKWvbf2nqRLxRLpiQM/qzm+XMp0cWKsIRxZnvwR5IFswvZ8Sx3ZI 7q+xDCXAxyjzpm9OuyTY3nLExw== X-Google-Smtp-Source: AK7set/aCj/6RUlMRa8YLjfXNAgQWi6CmMdvODO5LIRSwVpCey+4a2mR0eim95Ix+3SaJyy2MgIchA== X-Received: by 2002:a92:6810:0:b0:310:9adc:e1bb with SMTP id d16-20020a926810000000b003109adce1bbmr1421856ilc.0.1674766643095; Thu, 26 Jan 2023 12:57:23 -0800 (PST) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id f9-20020a022409000000b0039e048ad8e7sm756643jaa.59.2023.01.26.12.57.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 12:57:22 -0800 (PST) Message-ID: <7b3cbbd1-8c27-adf9-d2ed-c037f67bd697@linuxfoundation.org> Date: Thu, 26 Jan 2023 13:57:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] selftests: pci: pci-selftest: add support for PCI endpoint driver test Content-Language: en-US To: Bjorn Helgaas , Aman Gupta/FDS SW /SSIR/Engineer/Samsung Electronics Cc: 'Manivannan Sadhasivam' , shradha.t@samsung.com, pankaj.dubey@samsung.com, kishon@ti.com, lpieralisi@kernel.org, kw@linux.com, shuah@kernel.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, 'Padmanabhan Rajanbabu' , Shuah Khan References: <20230117195903.GA142672@bhelgaas> From: Shuah Khan In-Reply-To: <20230117195903.GA142672@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 1/17/23 12:59, Bjorn Helgaas wrote: > On Tue, Dec 27, 2022 at 10:45:26AM +0530, Aman Gupta/FDS SW /SSIR/Engineer/Samsung Electronics wrote: >> ... >> Thanks for review and suggestion. I understand that we would like to >> reuse and preserve the history of tools/pci/pcietest.c. So we have >> two approaches: >> >> 1: Using git mv command move existing code from tools/pci/ to >> tools/testing/selftest/drivers/pci/ and then update the file to >> convert to kselftest framework. I thought about this but after >> movement, when we move it to kselftest format it is going to be huge >> churn and we will be having modification in almost all lines. >> >> 2: Develop kselftest based driver in >> tools/testing/selftest/drivers/pci/ and eventually delete existing >> file from tools/pci/ folder providing justification in commit >> message. >> >> From my viewpoint, going with the second approach makes more sense >> because if almost complete file is getting modified, and it will >> make the review process complex and anyways there is not much code >> reusability. >> >> Please let me know if you have any other thought >> process or if I am missing anything to understand your approach. > > I vote for the first approach, with "git mv" and subsequent conversion > (in separate patches, of course). If git knows about the move, > "git log --follow" will be useful even though the conversion will be a > big patch. Adding a new test with the connection to the old one only > in the commit log makes more work for people who dig through the > history in the future. > Thanks Bjorn for explaining this in more detail that I did. Please send revised patches following the first approach. thanks, -- Shuah