Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Cc: linux-pci@vger.kernel.org, bhelgaas@google.com,
	linux-kernel@vger.kernel.org, sumanesh.samanta@broadcom.com,
	sathya.prakash@broadcom.com
Subject: Re: [PATCH 2/2] pci/p2pdma: Modify p2p_dma_distance to detect virtual P2P links
Date: Sat, 10 Aug 2024 13:33:14 -0600	[thread overview]
Message-ID: <7d74ee82-a529-4f1e-b46c-fcc59e8edda2@deltatee.com> (raw)
In-Reply-To: <20240621204737.GA1374564@bhelgaas>

Hi,

On 2024-06-21 14:47, Bjorn Helgaas wrote:
> [+cc Logan]
> 
> On Wed, Jun 12, 2024 at 04:27:36AM -0700, Shivasharan S wrote:
>> Update the p2p_dma_distance() to determine virtual inter-switch P2P links
>> existing between two switches and use this to calculate the DMA distance
>> between two devices.
>>

I've reviewed this and the previous patch to the best of my current
ability and I haven't seen anything major to object to. The changes to
the P2P code specifically look good (once Bjorn's comments are addressed).

Please copy me on future postings and I'll do another pass with a
Reviewed-By tag.

Thanks,

Logan

      reply	other threads:[~2024-08-10 20:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12 11:27 [PATCH 0/2] pci/switch_discovery: Add new module to discover inter-switch P2P links Shivasharan S
2024-06-12 11:27 ` [PATCH 1/2] switch_discovery: Add new module to discover inter switch links between PCI-to-PCI bridges Shivasharan S
2024-06-13 12:40   ` Jonathan Cameron
2024-06-14 15:36     ` Sumanesh Samanta
2024-06-23 14:44       ` Manivannan Sadhasivam
2024-06-21 20:53   ` Bjorn Helgaas
2024-06-24 19:31     ` Logan Gunthorpe
2024-06-12 11:27 ` [PATCH 2/2] pci/p2pdma: Modify p2p_dma_distance to detect virtual P2P links Shivasharan S
2024-06-21 20:47   ` Bjorn Helgaas
2024-08-10 19:33     ` Logan Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d74ee82-a529-4f1e-b46c-fcc59e8edda2@deltatee.com \
    --to=logang@deltatee.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sathya.prakash@broadcom.com \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=sumanesh.samanta@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox