From: James Puthukattukaran <james.puthukattukaran@oracle.com>
To: Alex Williamson <alex.williamson@redhat.com>,
Sinan Kaya <okaya@codeaurora.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: [PATCH 0/2] PCI: SUpport to workaround bus level HW issues
Date: Tue, 24 Apr 2018 10:51:35 -0400 [thread overview]
Message-ID: <7e9f5905-34c5-f24c-8b13-df36b8bf3621@oracle.com> (raw)
There are bugs in certain PCIe switches that cause access violations when an
endpoint device is hotplugged. In particular, there's an issue with
certain IDT switches that trigger a ACS violation when bringing up a newly
plugged PCIe endpoint device. This is a major issue for platforms
designed to issue a fatal reset in the case of this event.
The first patch provides a framework for intercepting and working around
issues with parent devices to the endpoint being brought up.
The second patch provides the actual patch for the IDT switch issue using
that framework. The ACS feature is disabled in the IDT switch prior to endpoint
device detection and then re-enabled subsequent to that.
James
-v2: move workaround to pci_bus_read_dev_vendor_id() from pci_bus_check_dev()
and move enable_acs_sv to drivers/pci/pci.c -- by Yinghai
-v3: add bus->self check for root bus and virtual bus for sriov vfs.
-v4: only do workaround for IDT switches
-v5: tweak pci_std_enable_acs_sv to deal with unimplemented SV
-v6: Added errata verbiage verbatim and resolved patch format issues
-v7: changed int to bool for found and idt_workaround declarations. Also
added bugzilla https://bugzilla.kernel.org/show_bug.cgi?id=196979
-v8: Rewrote the patch by adding a new acs quirk to keep the workaround
out of the main code path
-v9: changed function name from pci_dev_specific_fixup_acs_quirk to
pci_bus_acs_quirk. Also, tested for FLR and hot reset scenarios and did
not see issues where workaround was required. The issue seems to be
related only to cold reset/power on situation.
-v10: Moved the contents of pci_bus_read_vendor_id into an internal function
__pci_bus_read_vendor_id
-v11: Split the patch into two patches. The first a general quirk framework.
-v12: Add pci_bus_generic_read_dev_vendor_id() to carry out default behavior
when detecting endpoint and pci_bus_specific_read_dev_vendor_id for
bus quirk behavior
---
James Puthukattukaran (2):
PCI: Add pci_bus_specific_read_dev_vendor_id() to workaround PCI
switch specific issues prior to accessing newly added endpoint
PCI: Implement workaround for the ACS bug in the IDT switch
drivers/pci/pci.h | 4 ++
drivers/pci/probe.c | 19 ++++++-
drivers/pci/quirks.c | 138 +++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 160 insertions(+), 1 deletion(-)
--
1.8.3.1
next reply other threads:[~2018-04-24 14:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 14:51 James Puthukattukaran [this message]
2018-04-24 14:53 ` [PATCH 1/2] PCI: Add pci_bus_specific_read_dev_vendor_id() to workaround PCI switch specific issues prior to accessing newly added endpoint James Puthukattukaran
2018-04-24 17:50 ` Alex Williamson
2018-04-26 6:26 ` kbuild test robot
2018-04-26 19:32 ` James Puthukattukaran
2018-04-26 19:42 ` Alex Williamson
2018-04-26 19:45 ` Sinan Kaya
2018-04-26 8:53 ` kbuild test robot
2018-04-24 14:54 ` [PATCH 2/2] PCI: Implement workaround for the ACS bug in the IDT switch James Puthukattukaran
2018-04-24 17:50 ` Alex Williamson
-- strict thread matches above, loose matches on Subject: below --
2018-04-19 17:36 [PATCH 0/2] PCI: Support to workaround bus level HW issues James Puthukattukaran
2018-04-19 18:08 ` Alex Williamson
2018-04-24 14:57 ` James Puthukattukaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e9f5905-34c5-f24c-8b13-df36b8bf3621@oracle.com \
--to=james.puthukattukaran@oracle.com \
--cc=alex.williamson@redhat.com \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).